Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Skill search/ JD search is not returning matching roles #342

Closed
sdgun opened this issue Jun 21, 2021 · 7 comments
Closed

Skill search/ JD search is not returning matching roles #342

sdgun opened this issue Jun 21, 2021 · 7 comments

Comments

@sdgun
Copy link

sdgun commented Jun 21, 2021

Steps
Go to https://platform.topcoder-dev.com/taas/myteams/createnewteam/
Click select button in INPUT SKILLS box OR INPUT JOB DESCRIPTION
Select a skill (or enter JD) that matches the skills of an existing role >> click search

Current behavior
Only return the custom role

No.roles.mp4
@nikolay83
Copy link
Collaborator

@sdgun but it did work on prod last week, right?

@sdgun
Copy link
Author

sdgun commented Jun 22, 2021

@nikolay83 Yes it's working in prod still.

@nikolay83
Copy link
Collaborator

@urwithat Can it be something with ES index on dev?

@eisbilir
Copy link

@nikolay83

Examples:
requestSkills = {A, B, C} and roleSkills = {C, E, B, F, G} = > skillsMatch is 67%requestSkills = {A} and roleSkills = {A, C, E, B, F, G} = > skillsMatch is 100%
requestSkills = {A} and roleSkills = {C, E, B, F, G} = > skillsMatch is 0%
requestSkills = {A, B, C, D} and roleSkills = {A, B, C, F} = > skillsMatch is 75%
requestSkills = {A, B, C, D} and roleSkills = {A, B, C} = > skillsMatch is 75%

Skills matching logic is working just as you described above.

However, it can't match given skills with role's skills after this commit topcoder-platform/taas-apis@eb4afdb because we should not convert the skill names to lowercase. The endpoint accepts roleIds. And role object stores the skills by names in their original form. So we don't need the skill names in lowercase at all, otherwise it can't match.
Here is the fix: topcoder-platform/taas-apis#374

@nikolay83
Copy link
Collaborator

thank you @eisbilir! I merged it.

@sdgun
Copy link
Author

sdgun commented Jun 23, 2021

Verified in Dev, this issue is fixed.

@sdgun
Copy link
Author

sdgun commented Jun 24, 2021

Verified in production, the issue is fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants