Skip to content

Users should be able to delete their own submissions #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sushilshinde opened this issue Apr 27, 2020 · 11 comments
Open

Users should be able to delete their own submissions #175

sushilshinde opened this issue Apr 27, 2020 · 11 comments
Assignees

Comments

@sushilshinde
Copy link
Contributor

sushilshinde commented Apr 27, 2020

Problem described in the topcoder-platform/community-app#4213

Cause: V5 submission API delete endpoint only allows admin roles to delete the submissions.

Effect: Community app is using V3 delete endpoint instead of v5, which is probably wrong as back DB is architecture is different for V5, and submissions doesn't reflect the delete action.

Requirement: Users should be able to delete their own submissions

@Oanh-and-only-Oanh @callmekatootie

@callmekatootie
Copy link
Contributor

@sushilshinde

  • Is the deletion allowed only if the submission phase is still active?
  • What should happen to the reviews of the submission, example, the anti virus scan review...

@sushilshinde
Copy link
Contributor Author

@Oanh-and-only-Oanh please help with these questions

@Oanh-and-only-Oanh
Copy link

@callmekatootie,

  1. only allow delete option if submission phase is still active
  2. If submission is deleted, review of submission should end and be discarded. This is a permanent action from our servers that can't be undone.

@callmekatootie
Copy link
Contributor

@Oanh-and-only-Oanh @sushilshinde Should this be carried out immediately or should I hold until soft delete feature is implemented (Currently, there's no plan for soft delete yet but I am guessing it is in the pipeline)

@Oanh-and-only-Oanh
Copy link

@callmekatootie, what's the LOE and how long will it take to carry out now?

@callmekatootie
Copy link
Contributor

@Oanh-and-only-Oanh Should wrap up in 1-2 days

@callmekatootie
Copy link
Contributor

@Oanh-and-only-Oanh Just making sure - I am waiting on the go ahead from you here. I want to know if I can proceed or if I need to wait for Soft Delete.

Also - the 1-2 days timeline is for the feature request in this ticket - NOT for soft delete.

@Oanh-and-only-Oanh
Copy link

apologies for the late reply @callmekatootie. For some reason I don't get notified of mentions in github.

Yes, please more forward with feature request. thank you.

@callmekatootie
Copy link
Contributor

Status: PR ready. Reviewer assigned to review

callmekatootie added a commit that referenced this issue May 4, 2020
callmekatootie added a commit that referenced this issue May 4, 2020
callmekatootie added a commit that referenced this issue May 5, 2020
callmekatootie added a commit that referenced this issue May 5, 2020
* #175 - Allow users to delete their own submission

* #175 - Update tests

* #175 - Update POSTMAN collection

* #175 Fix review comments
@callmekatootie
Copy link
Contributor

@Oanh-and-only-Oanh the changes are in develop branch / dev instance of topcoder.

If we need to move the changes to production, kindly let me know

@cwdcwd
Copy link
Contributor

cwdcwd commented May 5, 2020

@callmekatootie hold on this.

@cwdcwd cwdcwd self-assigned this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants