[$60]Change submission API version v5 for DELETE calls #3575

Contest https://www.topcoder.com/challenges/30112871 has been updated - it has been assigned to daga_sumit.

This is an automated message for crazyk via Topcoder X

callmekatootie · 2020-01-16T10:41:47Z

208646 is most likely the legacy submission id. v5 submission api expects it to be a guid... and I am not sure which api one would call to get the v5 id from the legacy id...

@sushilshinde I am not sure about this. You might want to check with @cwdcwd or @dushyantb

callmekatootie · 2020-01-16T10:45:00Z

I typed too soon. My bad.

@sumitdaga So, use the legacy submission id, 208646 in this case and make the api call as follows:

GET https://api.topcoder-dev.com/v5/submissions?legacySubmissionId=208646 (with the relevant token) to get the submission details.

Here, you will get the v5 submission id, which you will then use in the v5 DELETE request

sumitdaga · 2020-01-16T10:49:17Z

@callmekatootie right, the V5 swagger doc also has this documented ..thanks!

sumitdaga · 2020-01-16T12:01:47Z

@sushilshinde
there seems to be some inconsistency between APIs ..i am not sure
i deleted two submissions after implementing it with V5 api
the submissions are successfully deleted as it does not show up here but they still show up here

sushilshinde · 2020-01-17T13:40:15Z

@sumitdaga can you PR the changes?

sumitdaga · 2020-01-17T13:48:34Z

@sushilshinde sure!
topcoder-platform/topcoder-react-lib#124

sumitdaga · 2020-01-21T07:09:21Z

@sushilshinde any update here ?

sumitdaga · 2020-02-06T10:32:08Z

@sushilshinde
i would say it is a bit strange to open an issue, have somebody work on it and submit an MR and then completely ignore the issue!

sushilshinde · 2020-02-11T03:56:34Z

Hey @sumitdaga sorry about that, I was stuck in the other issues. You will be paid for your work, don't worry about it.

LieutenantRoger · 2020-02-11T04:05:49Z

Hi @sumitdaga will review your submission, let me go through the issue now.

sumitdaga · 2020-02-11T06:47:39Z

@sushilshinde no worries, it is not about the money though!
thanks for checking in!

LieutenantRoger · 2020-02-11T09:33:51Z

Hi @sumitdaga

There are lint issue with the fix, could you please fix them ? Thanks

LieutenantRoger · 2020-02-11T13:18:39Z

Hi @sumitdaga

Which user you used to verify the delete submission ? I used TonyJ account, but it reported me this error:

https://take.ms/TdDA4

sumitdaga · 2020-02-11T13:45:40Z

@LieutenantRoger indeed i am getting the same error, but IIRC i was not getting this error when i had pushed the PR ...not sure!

LieutenantRoger · 2020-02-11T13:54:49Z

ok, thanks for checking out, let me get some clarification from the team.

sumitdaga · 2020-02-24T10:51:31Z

@LieutenantRoger
any update ?

LieutenantRoger · 2020-02-24T12:09:40Z

Thanks for the patient.

I haven't got time to test on current dev environment, the dev environment seems got reset recently. I'll check this later.

LieutenantRoger · 2020-02-24T15:34:42Z

Hi @sumitdaga

I just tried the fix, but receiving a lot of errors like this when launching community-app. https://take.ms/0RvkL
Will you please take a look as well and see if it works on your side ?

Thanks much.

sumitdaga · 2020-02-24T16:05:06Z

@LieutenantRoger I don't think these are due to my fixes/PR ...

LieutenantRoger · 2020-02-24T17:01:07Z

@LieutenantRoger I don't think these are due to my fixes/PR ...

Hmm，as it can't be verified now，could you please raise a new PR against our latest branch？The modification should only be on topcoder-react-lib，right？

LieutenantRoger · 2020-02-24T17:03:15Z

I will increase the price a bit for the extra work，Thanks much.

LieutenantRoger · 2020-03-03T13:27:56Z

Hi @sumitdaga

Sorry for the late response, we have got a base branch now, could you please work on hot-fix-delete-submission branch:

https://github.com/topcoder-platform/topcoder-react-lib/tree/hot-fix-delete-submission

Thanks

sumitdaga · 2020-03-03T14:37:55Z

Hey @LieutenantRoger
i updated the existing MR topcoder-platform/topcoder-react-lib#124 to use the above branch and there were no conflicts , so i guess its fine!

LieutenantRoger · 2020-03-05T06:59:09Z

Hmm, I believe you will have to merge hot-fix-delete-submission back into your local branch and verify, even though there's no conflict. The original base branch is very old, I don't think we can merge the PR like this.

sumitdaga · 2020-03-05T07:06:49Z

ok, sure, i will verify it when i can and let you know!

LieutenantRoger · 2020-03-16T14:21:16Z

https://take.ms/Nvb5F

The delete operation is returning 204 succeeded, though after we refresh the page, the deleted submission comes back. This might be a backend issue.

I'll approve this PR for now.

topcoder-platform/community-app#3575

SathyaJayabal · 2020-03-17T07:36:39Z

@LieutenantRoger , for MM "My Submissions " does not have delete option.

Develop Challenges do not have option to view/delete submissions

For design challenges there does not seem to be any api call to delete the submission and the submission is not getting deleted. Please see attached video.
cc @sushilshinde
delete sub.mov.zip

LieutenantRoger · 2020-03-17T13:00:18Z

Hi @SathyaJayabal

I tried the challenge in your video recording,

it looks we can delete the bottom two submissions. See the snapshot: https://take.ms/p425s
I tried to delete the second submission in the design challenge.

The one presented in your recording might be a wrong submission.

SathyaJayabal · 2020-03-17T14:12:30Z

@LieutenantRoger

The submission(209121) you have deleted for challenge (30054692) and user (TonyJ) is visible again.
I am not able to delete any of the three submissions for TonyJ, The api call for delete is not placed.
When logged in dan_developer and trying to delete a submission, the api returns an error

LieutenantRoger · 2020-03-18T06:20:28Z

Hi @sushilshinde

Please clarify above, we seems not on the same page for this ticket.

LieutenantRoger · 2020-03-18T09:36:45Z

Seems the same file can't be deleted twice, I switched to another MM challenge, and tried the delete operation
https://monosnap.com/file/jUjg2N1mBeqKsfNLvIuvE6V5emtO9t

sushilshinde · 2020-04-29T07:47:23Z

It can't be completed before this fix
topcoder-platform/submissions-api#175

sushilshinde added the tcx_OpenForPickup label Jan 16, 2020

sumitdaga self-assigned this Jan 16, 2020

sushilshinde changed the title ~~$[50]Change submission API version for DELETE calls~~ $[50]Change submission API version v5 for DELETE calls Jan 16, 2020

sushilshinde added tcx_Assigned and removed tcx_OpenForPickup labels Jan 16, 2020

sushilshinde changed the title ~~$[50]Change submission API version v5 for DELETE calls~~ [$50]Change submission API version v5 for DELETE calls Jan 16, 2020

sushilshinde added Prod QA Failed and removed Prod QA Failed labels Jan 20, 2020

sumitdaga removed their assignment Feb 6, 2020

sumitdaga removed the tcx_Assigned label Feb 6, 2020

sushilshinde assigned sumitdaga Feb 11, 2020

LieutenantRoger added the tcx_Assigned label Feb 11, 2020

LieutenantRoger changed the title ~~[$50]Change submission API version v5 for DELETE calls~~ [$60]Change submission API version v5 for DELETE calls Feb 24, 2020

sumitdaga mentioned this issue Mar 16, 2020

update DELETE submission api to V5 topcoder-platform/topcoder-react-lib#124

Merged

LieutenantRoger added tcx_FixAccepted and removed tcx_Feedback labels Mar 16, 2020

sushilshinde added a commit to topcoder-platform/topcoder-react-lib that referenced this issue Mar 17, 2020

Npm test release version bump up for

fc88090

topcoder-platform/community-app#3575

LieutenantRoger added Dev Env Ready for QA labels Mar 17, 2020

SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Mar 17, 2020

Oanh-and-only-Oanh removed the tcx_FixAccepted label Apr 17, 2020

[$60]Change submission API version v5 for DELETE calls #3575

[$60]Change submission API version v5 for DELETE calls #3575

Comments

sushilshinde commented Jan 16, 2020 • edited Loading

sumitdaga commented Jan 16, 2020 • edited Loading

sushilshinde commented Jan 16, 2020

callmekatootie commented Jan 16, 2020

sumitdaga commented Jan 16, 2020

crazyk07 commented Jan 16, 2020

crazyk07 commented Jan 16, 2020

callmekatootie commented Jan 16, 2020

callmekatootie commented Jan 16, 2020

sumitdaga commented Jan 16, 2020

sumitdaga commented Jan 16, 2020 • edited Loading

sushilshinde commented Jan 17, 2020

sumitdaga commented Jan 17, 2020

sumitdaga commented Jan 21, 2020

sumitdaga commented Feb 6, 2020

sushilshinde commented Feb 11, 2020

LieutenantRoger commented Feb 11, 2020

sumitdaga commented Feb 11, 2020

LieutenantRoger commented Feb 11, 2020

LieutenantRoger commented Feb 11, 2020

sumitdaga commented Feb 11, 2020

LieutenantRoger commented Feb 11, 2020

sumitdaga commented Feb 24, 2020

LieutenantRoger commented Feb 24, 2020

LieutenantRoger commented Feb 24, 2020

sumitdaga commented Feb 24, 2020 • edited Loading

LieutenantRoger commented Feb 24, 2020

LieutenantRoger commented Feb 24, 2020

LieutenantRoger commented Mar 3, 2020

sumitdaga commented Mar 3, 2020

LieutenantRoger commented Mar 5, 2020

sumitdaga commented Mar 5, 2020

LieutenantRoger commented Mar 16, 2020

SathyaJayabal commented Mar 17, 2020

LieutenantRoger commented Mar 17, 2020

SathyaJayabal commented Mar 17, 2020

LieutenantRoger commented Mar 18, 2020

LieutenantRoger commented Mar 18, 2020 • edited Loading

sushilshinde commented Apr 29, 2020

sushilshinde commented Jan 16, 2020 •

edited

Loading

sumitdaga commented Jan 16, 2020 •

edited

Loading

sumitdaga commented Jan 16, 2020 •

edited

Loading

sumitdaga commented Feb 24, 2020 •

edited

Loading

LieutenantRoger commented Mar 18, 2020 •

edited

Loading