Skip to content

Issue Fix #11 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2019
Merged

Issue Fix #11 #5

merged 3 commits into from
Jun 19, 2019

Conversation

nahidshahin
Copy link
Contributor

Added arrow-small-up icon and loaded accordingly

issues-2432

@luizrrodrigues luizrrodrigues self-requested a review June 13, 2019 16:36
luizrrodrigues
luizrrodrigues previously requested changes Jun 13, 2019
View reviewed changes
Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nahidshahin Please this issue topcoder-platform/community-app#2438 in scope, need margin between title and icon.

@luizrrodrigues luizrrodrigues mentioned this pull request Jun 14, 2019
Closed
@nahidshahin nahidshahin dismissed luizrrodrigues’s stale review June 14, 2019 16:19

Feedback addressed

@luizrrodrigues luizrrodrigues self-requested a review June 15, 2019 04:23
luizrrodrigues
luizrrodrigues previously requested changes Jun 15, 2019
View reviewed changes
Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using nbsp to add space not allowed, please use CSS to add margin.
Screen Shot 2019-06-15 at 18 00 24

@nahidshahin
Copy link
Contributor Author

Using nbsp to add space not allowed, please use CSS to add margin.
Screen Shot 2019-06-15 at 18 00 24

@luizrrodrigues
feedback addressed

@luizrrodrigues luizrrodrigues changed the title Fix for issues#2432 Issue Fix #11 Jun 16, 2019
@luizrrodrigues luizrrodrigues self-requested a review June 16, 2019 02:52
@luizrrodrigues luizrrodrigues merged commit 47a5600 into topcoder-platform:develop Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizrrodrigues luizrrodrigues luizrrodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahidshahin @luizrrodrigues