Skip to content

$15 | All Sub menus> Sub-menu has an item after the menu name #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codejamtc opened this issue Jun 7, 2019 · 17 comments
Closed

$15 | All Sub menus> Sub-menu has an item after the menu name #11

codejamtc opened this issue Jun 7, 2019 · 17 comments
Assignees
Labels
Bug Hunt tickets logged from a Bug Hunt nav_Assigned nav_BugAccepted nav_FixAccepted nav_Paid P3 Normal (resolved within 7 days) UI

Comments

@codejamtc
Copy link

image

  1. Open the application https://test-community-app.topcoder-dev.com/challenges
  2. Login as dan_developer
  3. Tap Menu > Work > Tracks

Actual: Sub-menu should not display that extra item

Reproducibility Rate: 3/3

Environment: Pixel XL, Android 9

Browser: Chrome 75.0.3770.80

@nithyaasworld
Copy link
Collaborator

nithyaasworld commented Jun 9, 2019

It should display the collapsed and expanded arrow as necessary. Design reference:

Should be fixed for both Light and Dark Theme

image

@luizrrodrigues
Copy link
Collaborator

Please make sure to fix issue reported in #2438 too. (are related issues)

@luizrrodrigues luizrrodrigues self-assigned this Jun 9, 2019
@luizrrodrigues luizrrodrigues changed the title All Sub menus> Sub-menu has an item after the menu name $15 | All Sub menus> Sub-menu has an item after the menu name Jun 9, 2019
@nahidshahin nahidshahin self-assigned this Jun 11, 2019
@nahidshahin
Copy link
Contributor

PR #5

@luizrrodrigues luizrrodrigues transferred this issue from topcoder-platform/community-app Jun 13, 2019
@luizrrodrigues
Copy link
Collaborator

@nahidshahin Please check feedback in PR #5

@nahidshahin
Copy link
Contributor

@luizrrodrigues this task involves added Icon + place icons appropriately. The prize seems little bit small.

@luizrrodrigues
Copy link
Collaborator

I think is okay, second requirement is just add padding-left: 5px

@luizrrodrigues
Copy link
Collaborator

@nahidshahin Please check feedback here: #5 (review)

@luizrrodrigues
Copy link
Collaborator

@nahidshahin I do a double check in real device, wrong icon still showing in Android.

Check:
image

@luizrrodrigues
Copy link
Collaborator

@nahidshahin Please give me some status on this or if we can Open For Pickup

@r0hit-gupta
Copy link
Collaborator

@luizrrodrigues I would like to pick this up. Thanks.

@luizrrodrigues
Copy link
Collaborator

@r0hit-gupta Cool, thanks.

@r0hit-gupta
Copy link
Collaborator

@luizrrodrigues unable to reproduce. Can you please test again in Chrome's incognito mode? The cache might be a problem.

@luizrrodrigues
Copy link
Collaborator

@r0hit-gupta Note, this happen only in Android device

@r0hit-gupta
Copy link
Collaborator

Yes. It looks fine to me on OnePlus 6 - Android 8.1.0. Please try again once in incognito and if its still an issue, will look deeper into it.

@luizrrodrigues
Copy link
Collaborator

@r0hit-gupta Yeah, looks like was problem with caching.

Thanks for checking.

@nahidshahin
Copy link
Contributor

@luizrrodrigues sorry I was in travel. Just being curious, who has get paid?

@luizrrodrigues
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Hunt tickets logged from a Bug Hunt nav_Assigned nav_BugAccepted nav_FixAccepted nav_Paid P3 Normal (resolved within 7 days) UI
Projects
None yet
Development

No branches or pull requests

5 participants