issue #13 fix #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizrrodrigues
requested changes
Jun 13, 2019
There was a problem hiding this comment.
@rashmi73 You need deploy build to include change in build folder too, run:
npm install
npm run build
|
@luizrrodrigues done please check |
luizrrodrigues
pushed a commit
that referenced
this pull request
Jun 15, 2019
luizrrodrigues
previously approved these changes
Jun 15, 2019
|
@rashmi73 sorry, I merge another issue before that, can you update builds please? |
luizrrodrigues
requested changes
Jun 19, 2019
There was a problem hiding this comment.
@rashmi73 Sorry, I just merge your other issue and showing conflicts again.
luizrrodrigues
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.