Skip to content

$40 | New Nav - Mobile View UI Issues #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sushilshinde opened this issue Jun 3, 2019 · 20 comments
Closed

$40 | New Nav - Mobile View UI Issues #13

sushilshinde opened this issue Jun 3, 2019 · 20 comments
Assignees
@ThomasKranitsas @luizrrodrigues @rashmi73
Labels
nav_Assigned nav_FixAccepted nav_Paid P3 Normal (resolved within 7 days)

Comments

@sushilshinde
Copy link
Collaborator

Original Spec : https://marvelapp.com/1dgiejg6/screen/54473669

  1. Logo not in the center

not-in-the center

  1. Horizontal divider not aligned with text, also there is no X button to close the popup

Screenshot_20190603-160049

**Smartphone **

  • Device: MI A2
  • OS: Android 9
  • Chrome
@ThomasKranitsas
Copy link
Contributor

@sushilshinde what's the 3. TBD here?

@luizrrodrigues luizrrodrigues changed the title New Nav - Mobile View UI Issues $40 | New Nav - Mobile View UI Issues Jun 7, 2019
@rashmi73 rashmi73 self-assigned this Jun 8, 2019
@rashmi73
Copy link
Contributor

rashmi73 commented Jun 9, 2019

@luizrrodrigues PR on navigation component #2

@sushilshinde
Copy link
Collaborator Author

@luizrrodrigues can we proceed with this?

@luizrrodrigues luizrrodrigues transferred this issue from topcoder-platform/community-app Jun 13, 2019
@luizrrodrigues
Copy link
Collaborator

@rashmi73 Please check feedback in PR #2

@rashmi73
Copy link
Contributor

@luizrrodrigues updated

@luizrrodrigues
Copy link
Collaborator

@rashmi73

Logo: Looks good

Profile menu: Items need be aligned with green line.
Check:
image

@rashmi73
Copy link
Contributor

@luizrrodrigues confuse how much is to be aligned? can you please notify with green markers how it is to be made on above screenshot?

@luizrrodrigues
Copy link
Collaborator

@rashmi73 Need consistent alignment with Work menu:
https://marvelapp.com/89423f8/screen/54595272/handoff

image

@rashmi73
Copy link
Contributor

@luizrrodrigues you mean to say

  1. "My Dashboard" text is not in same line logo?

  2. so left of logo and "My Dashboard" should have equal space to the left?

@luizrrodrigues
Copy link
Collaborator

@rashmi73 check image bellow, this was shared before. What is not aligned is the dividers, text have right alignment.

What I see in your submission:
image

@rashmi73
Copy link
Contributor

@luizrrodrigues need like this?

https://marvelapp.com/89423f8/screen/55812232

@luizrrodrigues
Copy link
Collaborator

@rashmi73 Yes.

@rashmi73
Copy link
Contributor

@luizrrodrigues updating

@rashmi73
Copy link
Contributor

@luizrrodrigues updated
PR #2

@rashmi73
Copy link
Contributor

@luizrrodrigues can you please review this?

@luizrrodrigues
Copy link
Collaborator

@rashmi73 posting feedback shortly

@rashmi73
Copy link
Contributor

@luizrrodrigues PR updated
PR #2

@rashmi73
Copy link
Contributor

@luizrrodrigues PR updated
PR #2

1 similar comment
@rashmi73
Copy link
Contributor

@luizrrodrigues PR updated
PR #2

luizrrodrigues added a commit that referenced this issue Jun 19, 2019
@luizrrodrigues
Merge pull request #2 from rashmi73/issue_2398
dd9f429 
Fix Issue #13
@luizrrodrigues
Copy link
Collaborator

@rashmi73 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasKranitsas ThomasKranitsas

@luizrrodrigues luizrrodrigues

@rashmi73 rashmi73

Labels
nav_Assigned nav_FixAccepted nav_Paid P3 Normal (resolved within 7 days)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sushilshinde @ThomasKranitsas @luizrrodrigues @rashmi73