Skip to content

add signup component #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

add signup component #174

wants to merge 6 commits into from

Conversation

skyhit
Copy link

@skyhit skyhit commented May 13, 2020

No description provided.

@luizrrodrigues luizrrodrigues self-requested a review May 19, 2020 23:32
Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyhit Looks good.

@skyhit
Copy link
Author

skyhit commented May 20, 2020

@luizrrodrigues should I merge?

@luizrrodrigues
Copy link
Collaborator

@skyhit Nope, wait for @sushilshinde

This already pass in QA?

@skyhit
Copy link
Author

skyhit commented May 20, 2020

no for QA, yet.

@luizrrodrigues
Copy link
Collaborator

no for QA, yet.

Need pass for QA before merge to develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants