Skip to content

[$40] 'My book marks' count and the available book marks do not tally #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Dec 16, 2020 · 5 comments
Closed

[$40] 'My book marks' count and the available book marks do not tally #299

sdgun opened this issue Dec 16, 2020 · 5 comments

Comments

@sdgun
Copy link
Collaborator

sdgun commented Dec 16, 2020

Steps
Log into forums as sdguntcqa(T0pc0der@123) or TopConnCustomer(appirio123)
Check the count and the actual number of book marks in the Bookmarks section (https://vanilla.topcoder-dev.com/discussions/bookmarked)

The count and list do not tally

image

image

@sdgun sdgun added bug Something isn't working P3 Dev env labels Dec 16, 2020
@jmgasper jmgasper changed the title 'My book marks' count and the available book marks do not tally [$40] 'My book marks' count and the available book marks do not tally Dec 16, 2020
@jmgasper
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30158354 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30158354 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

atelomycterus commented Dec 16, 2020

@jmgasper Please apply PR: topcoder-platform/forums-groups-plugin#45. Thanks!

DEV

User 'TopConnCustomer'
3 discussions are not displayed because the user doesn't have permission to these discussions, not a member of the groups:
https://vanilla.topcoder-dev.com/discussion/1676 , not a member of https://vanilla.topcoder-dev.com/group/159
https://vanilla.topcoder-dev.com/discussion/1671 , not a member of https://vanilla.topcoder-dev.com/group/166
https://vanilla.topcoder-dev.com/discussion/1633 , not a member of https://vanilla.topcoder-dev.com/group/164

Bookmarks had been added before the issue (#178) was fixed.
Count of bookmarks is stored in User Profile table. This is a calculated column. It should be recalculated after adding/removing a bookmark, changing category permissions and so on.

User 'sdguntcqa'
User doesn't have permission to 2 discussions, not a member https://vanilla.topcoder-dev.com/group/185 .
https://vanilla.topcoder-dev.com/discussion/1753, not a member https://vanilla.topcoder-dev.com/group/185
https://vanilla.topcoder-dev.com/discussion/1751, not a member https://vanilla.topcoder-dev.com/group/185

I think this case:

I've fixed count of bookmarks after unregistering users.

Testing

Need to test this case:

  • User registers for a challenge, bookmarks discussions and unregisters from this challenge.
  • Count of bookmarks should be re-calculated.

DEV: After adding users to groups (registering for challenges) , unregister from challenges => count the number of bookmarks should be correct.

@jmgasper
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30158354

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator Author

sdgun commented Dec 17, 2020

My Bookmarks count calculated correct after unregistering from challenges, however there is an issue with My Discussions. Reported #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants