Skip to content

[$30] 'My Discussions' is not showing the correct count once a user unregisters from a challenge #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Dec 17, 2020 · 10 comments

Comments

@sdgun
Copy link
Collaborator

sdgun commented Dec 17, 2020

Steps

The My discussions count is still 4 but inside there are only 3 discussions

Screencast 2020-12-17.zip

@sdgun sdgun added bug Something isn't working P3 Dev env labels Dec 17, 2020
@jmgasper jmgasper changed the title 'My Discussions' is not showing the correct count once a user unregisters from a challenge [$30] 'My Discussions' is not showing the correct count once a user unregisters from a challenge Dec 17, 2020
@jmgasper
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30158655 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30158655 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper Need your help with this issue. My discussions page displays all discussions created by User.
On the one hand, if User has left the group, then there is no access to discussions.
On the other hand, User is the author and must see everything he\she has created.
In the old forum User can see post history:
image

Unfortunately, I cannot check this case (a user unregisters from a challenge) as it worked on the old forum due to using Vanilla forums.
Maybe you know?

taking into account group permissions, the list of discussions is correct = > fix count of discussions
OR
showing all discussions created by User , count of discussions is correct => fix the list of discussions, ignoring group permissions

@atelomycterus
Copy link
Collaborator

@jmgasper Maybe you missed my question:

Unfortunately, I cannot check this case (a user unregisters from a challenge) as it worked on the old forum due to using Vanilla forums.
Maybe you know?
taking into account group permissions, the list of discussions is correct = > fix count of discussions
OR
showing all discussions created by User , count of discussions is correct => fix the list of discussions, ignoring group permissions

@jmgasper
Copy link
Collaborator

Let's do this:

taking into account group permissions, the list of discussions is correct = > fix count of discussions

@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PRs:

Testing

  • Register for a challenge and create discussions.
  • Unregister from the challenge. My Discussions Count should be updated. All previously created discussions shouldn't be displayed in My discussions.
  • Register again for the challenge. My Discussions count should be updated. All previously created discussions should be displayed in My discussions.

@jmgasper
Copy link
Collaborator

jmgasper commented Jan 1, 2021

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30158655

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator Author

sdgun commented Jan 8, 2021

Verified.

Unregistering from the challenge is updating the My Discussions Count and previously created discussions are not displayed in My discussions. Register again updates the My Discussions count and all previously created discussions are displayed in My discussions.

@sdgun sdgun added the QA Pass label Jan 8, 2021
@jmgasper jmgasper added this to the January 2021 Release milestone Jan 11, 2021
@sdgun
Copy link
Collaborator Author

sdgun commented Jan 25, 2021

Unable to verify in production due to #358 (comment)

@sdgun
Copy link
Collaborator Author

sdgun commented Jan 28, 2021

Verified in production, the counts are adjusted after the user unregisters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants