[$150] Challenge discussions are accessible to the user even after unregister from the challenge

[sdgun]

Steps
Log in as TopConnCustomer and check the bookmarks (should have a discussion book marked from an existing forum)
Unregister from the challenge and check the book marks again

Actual result
Book marks list still show the unregistered challenge's bookmarked discussion and the user can continue creating new discussions and adding comment etc on the same challenge forum

Bookmark after unregister.zip

[jmgasper]

TopConnCustomer isn't a normal user, are they? They may have multiple roles on a challenge, so even if they unregister, they could still be part of the challenge under and Observer role.

[sdgun]

@jmgasper This user is not in connect project or in OR. I also checked from normal user 'sdguntcqa'. However I am not sure why we are showing Roles=Member, Topcoder User in forum profile page

[jmgasper]

Contest https://www.topcoder.com/challenges/30150820 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

[jmgasper]

Contest https://www.topcoder.com/challenges/30150820 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

[atelomycterus]

Fixed.

I'll create PR after fixing other issues with permissions. I've made a lot of changes.

Notes for testers
Count of Bookmarks in the nav should be correct after unregistering from the challenges,

[atelomycterus]

@jmgasper If User creates a discussion in a group and leaves the group.
Should the discussion be displayed in http://127.0.0.1/discussions/mine after leaving a group or removing from a group?

Need to display the correct count of 'My Discussions'

[jmgasper]

@atelomycterus - No, I think we can leave that as-is for now.

[atelomycterus]

@jmgasper Please apply PRs:
PRs:
topcoder-platform/forums-plugins#45
#192
topcoder-platform/forums-groups-plugin#24
topcoder-platform/challenge-forum-processor#42

I added a new column to Category table. So it affects the plugins and the processor. The data will be updated automatically as we have a unique urlcode in Db and we can understand which group it belongs to, checking the permissions of groups is added to the CategoryModel. Otherwise, lead to issues with access rights It's not possible to manage it with hooks and virtual methods (Vanilla feature).

[jmgasper]

@sdgun - We can test this, but note hit will only apply to newly created challenges

[jmgasper]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30150820

This is an automated message for ghostar via Topcoder X

[sdgun]

Verified, this issue is fixed