-
Notifications
You must be signed in to change notification settings - Fork 0
[$60] When there are comments across multiple pages, when user selects a view from 1st page, it's opening the page 2 #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Contest https://www.topcoder.com/challenges/30155619 has been created for this ticket. |
Contest https://www.topcoder.com/challenges/30155619 has been updated - it has been assigned to obog. |
@jmgasper I've looked at the old forums. Flat view supports paging. Tree View/ Threaded View doesn't support paging and all comments are displayed on one page. The number of comments is 3-20 per a discussion. Let me know if you are ok if Tree View/Threaded View doesn't support paging. Example an old forum with 50+ comments: Flat View - https://apps.topcoder.com/forums/?module=Thread&threadID=684003&start=0 , there are 2 pages. |
Yeah, that's fine. If we're consistent with the old forums, people should be happy with that, thanks. |
@jmgasper Done. Please apply PRs: topcoder-platform/forums-plugins#53, ViewsFlat View is set by default and supports 'CommentsAutoOffset'. If there are several pages of comments, the discussion meta/body/view mode is shown on the first page only. I've fixed the view mode. It is always displayed. Otherwise, User would need to return to the first page to change view mode. CommentsAutoOffsetIf there are several pages of comments then the appropriate offset (page) is calculated (based on the user's read comments & comments per page). User is automatically pushed to the comment he/she reads in a discussion. For testing I set comments per page = 5 in my local env. At first it was unexpected why I ended up on the third page when I come to the discussion page. If you want to disable this feature:
|
Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30155619 |
Verified, the pagination for threaded and tree views are removed. |
Steps
Log in as copilot user and go to any discussion(ex- https://vanilla.topcoder-dev.com/discussion/1889/code-docs-inside/p1)
Select Tree view or Threaded view
Navigates to page 2
Screencast 2020-12-03.zip
The text was updated successfully, but these errors were encountered: