Skip to content

In Threaded view the page numbers are not displayed #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Mar 27, 2021 · 5 comments
Closed

In Threaded view the page numbers are not displayed #498

sdgun opened this issue Mar 27, 2021 · 5 comments

Comments

@sdgun
Copy link
Collaborator

sdgun commented Mar 27, 2021

Steps
Go to a discussion with more than 1 page of comments(ex-https://vanilla.topcoder-dev.com/discussion/3559/perf-2?view=threaded)

Pagination is not there

Screencast.2021-03-27.mp4
@sdgun sdgun added bug Something isn't working Dev env P1 labels Mar 27, 2021
@atelomycterus
Copy link
Collaborator

@sdgun Now Threaded View is default (#395). Threaded View doesn't support paging, all comments are displayed on one page - #256 (comment)

Flat View supports paging.

@sdgun
Copy link
Collaborator Author

sdgun commented Mar 28, 2021

@atelomycterus Thanks, A few issues I found, please let me know if you want me to report them separately

  1. For anonymous users, Threaded view supports pagination

image

  1. For anonymous users, the comments on the first page of threaded view do not display the text "Re: ..."
Screencast.2021-03-28.mp4

@atelomycterus
Copy link
Collaborator

@sdgun I've fixed views for anonymous in (#504,
topcoder-platform/forums-plugins#76). If you find new issues, please report them separately. Thanks!

@sdgun
Copy link
Collaborator Author

sdgun commented Mar 29, 2021

Verified the pagination and the reference text on comments for anonymous users in Dev. The issues are fixed.

@sdgun
Copy link
Collaborator Author

sdgun commented Apr 1, 2021

Verified in production.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants