Skip to content

[$30] When new page is created in a discussion, the view is reset to Flat #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Dec 3, 2020 · 6 comments
Closed

Comments

@sdgun
Copy link
Collaborator

sdgun commented Dec 3, 2020

Steps
Log in as copilot user and go to any discussion(ex- https://vanilla.topcoder-dev.com/discussion/1889/code-docs-inside/p1) - delete the comment in the 2nd page to easily recreate this
Select Tree view or Threaded view
Keep creating comments/replies until second page is created
Once page 2 is created,
Click either 'Previous' or page 1 to go back to page 1
Check the view

The view is reset to Flat

Screencast 2020-12-03.zip

@sdgun sdgun added bug Something isn't working Dev env P4 labels Dec 3, 2020
@jmgasper jmgasper changed the title When new page is created in a discussion, the view is reset to Flat [$30] When new page is created in a discussion, the view is reset to Flat Dec 3, 2020
@jmgasper
Copy link
Collaborator

jmgasper commented Dec 3, 2020

Contest https://www.topcoder.com/challenges/30155618 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

jmgasper commented Dec 3, 2020

Contest https://www.topcoder.com/challenges/30155618 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper Related Issue- #256. Need your feedback with tree/threaded view+ paging.

@atelomycterus
Copy link
Collaborator

@jmgasper. Fixed with #256.

@jmgasper
Copy link
Collaborator

jmgasper commented Dec 4, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30155618

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator Author

sdgun commented Dec 8, 2020

Verified, this issue is fixed. The Threaded and Tree views do not use pagination now.

@sdgun sdgun added this to the 1.0 milestone Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants