Skip to content

fix challenge update #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 17, 2023
Merged

fix challenge update #10

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8ea1c02
fix challenge update
ThomasKranitsas Mar 14, 2023
d38f7fe
use latest version of the framework
ThomasKranitsas Mar 16, 2023
8ec40bd
add some logging
ThomasKranitsas Mar 16, 2023
b637530
add some logging
ThomasKranitsas Mar 16, 2023
a852eed
change logging and add try/catch
ThomasKranitsas Mar 16, 2023
acdc55d
fix: update protos
ThomasKranitsas Mar 17, 2023
07a8f8d
disable associateChallengeTerms
ThomasKranitsas Mar 17, 2023
9573c26
fix issue with terms
ThomasKranitsas Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const protoConfig = [
`--descriptor_set_out ${PROTO_REFLECTIONS}`,
`--proto_path ${PROTO_DIR} ${PROTO_DIR}/common/*.proto`,
`--proto_path ${PROTO_DIR} ${PROTO_DIR}/domain-layer/challenge/*.proto`,
`--proto_path ${PROTO_DIR} ${PROTO_DIR}/domain-layer/legacy/*.proto`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need legacy here? This doesn't seem right. domain-challenge should not be building legacy models - that's a function of ACL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were using a legacy model which was throwing an import error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we point to it please - I'll take a look. But we should be importing legacy stuff here - if we did it's a mistake Any imports must come through domain-acl.

`--proto_path ${PROTO_DIR} ${PROTO_DIR}/domain-layer/challenge/services/*.proto`,
];

Expand Down
4 changes: 4 additions & 0 deletions src/common/Constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,7 @@ export const ProjectInfoIds = {
export const ResourceInfoIds = {
CopilotPayment: 7,
};

export const ChallengeStatuses = {
New: 'New',
};
Loading