fix challenge update #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakibansary
reviewed
Mar 14, 2023
| @@ -31,6 +31,7 @@ const protoConfig = [ | |||
| `--descriptor_set_out ${PROTO_REFLECTIONS}`, | |||
| `--proto_path ${PROTO_DIR} ${PROTO_DIR}/common/*.proto`, | |||
| `--proto_path ${PROTO_DIR} ${PROTO_DIR}/domain-layer/challenge/*.proto`, | |||
| `--proto_path ${PROTO_DIR} ${PROTO_DIR}/domain-layer/legacy/*.proto`, | |||
There was a problem hiding this comment.
Why do we need legacy here? This doesn't seem right. domain-challenge should not be building legacy models - that's a function of ACL
There was a problem hiding this comment.
You were using a legacy model which was throwing an import error
There was a problem hiding this comment.
Can we point to it please - I'll take a look. But we should be importing legacy stuff here - if we did it's a mistake Any imports must come through domain-acl.
rakibansary
suggested changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.