Filter update -- fix issue 5068's comments

[nqviet]

issuecomment-741596441: (1) intentional, (2) fixed: layout issue, (3) fixed: after coming back from the challenge details, the default tab is 'Active' and default bucket is 'Open for registration'
issuecomment-741600474: fixed: layout issue
issuecomment-741904592: fixed: forgot to set the challenge 'types' filter to all when clicking on the challenge Tags

 

About 741904592: search=<tag> vs tags[]=<tag>

• There are modules of the community-app allowing to search by multiple tags (ex: Contentful EDU search) while search=<tag> is allowing searching by a single tag only
• search=<tag> searching in challenges' name, description and tags, so there is a confused case that a challenge with only HTML tag but its description including the keyword 'Java' still being listed when user clicking on the 'Java' tag under the header of some challenge details.

So I think tags[]=<tag> is better than search=<tag> and its search results will be the same as the results of the old filter panel.

[maxceem]

There are modules of the community-app allowing to search by multiple tags (ex: Contentful EDU search) while search= is allowing searching by a single tag only

@nqviet thank you for suggestions regarding tags. Could you please, share some link/screenshot where we have a search by multiple tags, cannot find such an example by myself.

search= searching in challenges' name, description and tags, so there is a confused case that a challenge with only HTML tag but its description including the keyword 'Java' still being listed when user clicking on the 'Java' tag under the header of some challenge details.

This is an intentional change. We are making search more "intelligent" type into search field what you need, and we would show it. This is to get rid of the complex search UI.

[maxceem]

Fixes look good. The only thing there is no way to close the calendar in mobile view anymore. Before there was a "close" icon in the top right corner.

[nqviet]

There are modules of the community-app allowing to search by multiple tags (ex: Contentful EDU search) while search= is allowing searching by a single tag only

@nqviet thank you for suggestions regarding tags. Could you please, share some link/screenshot where we have a search by multiple tags, cannot find such an example by myself.

@maxceem There is still one place where /?tags[]=[<tag1>]&tags[]=<tag2> is still applied in the Contentful module.

[maxceem]

Thanks for the quick update, @nqviet

It looks like the place you've mentioned in the code is not related to challenges searching but is for searching articles in Thrive, see screenshot https://monosnap.com/file/fHAMyTfc2cvzvBSYlje5bHRJfKKwog.

So we should be safe to use "search" for filtering challenges by tags.

So I'm passing this to QA team, to check if all is good now.