Skip to content

update filtering UI on challenge listing #5068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Oanh-and-only-Oanh opened this issue Oct 8, 2020 · 46 comments
Closed

update filtering UI on challenge listing #5068

Oanh-and-only-Oanh opened this issue Oct 8, 2020 · 46 comments
Assignees
Labels
Challenge Listing New feature P2 Important (resolve within 3 days) QA Pass in PROD Passed verification on Production
Milestone

Comments

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Oct 8, 2020

Currently, the calendar interface on the challenge listings page is not user friendly. See below
image

Update:
We'd like to update the calendar UI so that it is easier for members to input dates without having to click though the calendar.

@Oanh-and-only-Oanh Oanh-and-only-Oanh added New feature Challenge Listing P2 Important (resolve within 3 days) labels Oct 8, 2020
@Oanh-and-only-Oanh
Copy link
Author

Design f2f copiloted by eriantoongko

@eriantoongko eriantoongko self-assigned this Oct 9, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title update date filter UI on challenge listing update datepicker UI on challenge listing Oct 12, 2020
@maxceem
Copy link
Contributor

maxceem commented Oct 13, 2020

@Oanh-and-only-Oanh in general the task looks clear.

The only question is there UI for choosing month and year?

image

@eriantoongko
Copy link
Collaborator

@maxceem @Oanh-and-only-Oanh I will ask the winner to provide the UI and keep you guys updated.

@eriantoongko
Copy link
Collaborator

@maxceem @Oanh-and-only-Oanh month and year interaction added to the previous link.

@maxceem
Copy link
Contributor

maxceem commented Oct 13, 2020

Thanks, @eriantoongko.

Is it desired to implement a custom scrollbar for a month and year dropdowns, or we can use standard browser scrollbars? (I would recommend going with the standard ones).

image

@Oanh-and-only-Oanh
Copy link
Author

@eriantoongko, would it be possible to see what a standard browser scrollbar look like

@eriantoongko
Copy link
Collaborator

@Oanh-and-only-Oanh actually what the designer using right now is a mac version scroll bar. I attach my chrome scroll bar.
Screen Shot 2020-10-13 at 9 48 31 PM

@eriantoongko
Copy link
Collaborator

@maxceem I think that is fine. We should use the native scrollbar provided by the OS.

@Oanh-and-only-Oanh
Copy link
Author

Oanh-and-only-Oanh commented Oct 13, 2020

@eriantoongko, I don't think it's clear in the design that it's 2 separate calendars for choosing 2 dates (start and end). When user opens calendar for start date, only the exact date should be highlighted. Is it not a range like shown below.
image

I also think it could still be clearer to the user that the calendar is for the "start" date field.

@maxceem
Copy link
Contributor

maxceem commented Oct 13, 2020

Ah, yes, I did think that this calendar is for choosing a range because it is highlighting a range and it also suggests choosing several predefined ranges on the left:

image

Another note from a non-USA citizen. I can see that the date format has been changed from Nov 12 2000 to 11/12/2000 so it can be entered from the keyboard. Just would like to note, that outside USA the date has another format: DD/MM/YYYY instead of MM/DD/YYYY. So non-USA citizens cannot be sure what date is shown as 11/12/2000 as it looks ambiguous.

@maxceem
Copy link
Contributor

maxceem commented Oct 14, 2020

@Oanh-and-only-Oanh just would like to confirm, that we also require that all the functionality should be accessible from the keyword:

  • Calendar should be accessible using the keyword. We should be able to choose any date using keys <Tab>/<Shift>+<Tab>/<Enter> as it's implemented in the current calendar.

  • We should also be able to enter dates from the keyword directly to the inputs using the input mask.

    image

    It should automatically move the cursor during input, allow us to put the cursor in any place and allow using keyboard arrows to navigate between digits, something like in this demo.

@Oanh-and-only-Oanh
Copy link
Author

@maxceem that's correct. All functionality should be accessible from keyboard. @eriantoongko, can we update the style to fit the 2018 look and feel - more on the blue colors than green. Thank you.

@eriantoongko
Copy link
Collaborator

eriantoongko commented Oct 14, 2020

@maxceem
Copy link
Contributor

maxceem commented Oct 15, 2020

@Oanh-and-only-Oanh let me confirm the workflow:

  1. When the user selects the first date, there are 3 ways to go:

    1. Let the user select the second date immediately after selecting the first date (as it's done now).
    2. Keep the calendar open so the user can select another first date.
    3. Close calendar immediately after selecting the first date.

    image

  2. To make the calendar accessible from the keyboard we have to highlight a selected element when the user uses the keyboard, see demo:

    Oct-15-2020 10-20-03

    We can use the same blue square as we do now, or would you like to highlight it another way in the new UI?

  3. To confirm. Previously, we show a calendar widget when we click at any place in the input field:

    image

    As now we can enter the date from the keyboard, to open the calendar we have to click on the calendar icon only:

    image

@Oanh-and-only-Oanh
Copy link
Author

@maxceem,

  1. When the user selects the first date, let the user select the second date immediately after selecting the first date (as it's done now).

2.The same blue square is fine. I just want to ensure it is keyword accessible.

  1. Correct. user can enter the exact date or use the calendar feature by clicking on the calendar icon.

@Oanh-and-only-Oanh
Copy link
Author

@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title update datepicker UI on challenge listing update filtering UI on challenge listing Dec 7, 2020
@maxceem
Copy link
Contributor

maxceem commented Dec 7, 2020

One more challenge is done to update the challenge filter UI in general https://www.topcoder.com/challenges/4d9f86b5-f492-4b31-bad0-521098798037?tab=details

There are 2 PRs:

Submission is almost perfect, there are only a few minor issues:

We would fix these issues after QA together with other issues found during QA.

@maxceem
Copy link
Contributor

maxceem commented Dec 9, 2020

Note, final fixes are now done for items 1-8.

New items 1-3 #5068 (comment) and #5068 (comment) are not yet fixed.

@Oanh-and-only-Oanh
Copy link
Author

@Oanh-and-only-Oanh , the keywords filter option is missing in the design. Is this intentional?
https://marvelapp.com/prototype/96cb17f/screen/74488185

@maxceem and @SathyaJayabal, this is intentional. we've condensed the functionality of the search bar so it can be used to search keyword, tags, and title. This was an enhancement of search feature made by @rootelement

@SathyaJayabal
Copy link
Collaborator

@Oanh-and-only-Oanh , the keywords filter option is missing in the design. Is this intentional?
https://marvelapp.com/prototype/96cb17f/screen/74488185

@maxceem and @SathyaJayabal, this is intentional. we've condensed the functionality of the search bar so it can be used to search keyword, tags, and title. This was an enhancement of search feature made by @rootelement

@maxceem , in this case, when a user clicks on any of the challenge tags, the url should be (example user clicks on tag swagger)
https://staging-community-app.topcoder.com/challenges?search=swagger&tracks[DS]=true&tracks[Des]=true&tracks[Dev]=true&tracks[QA]=true&types[]=CH&types[]=F2F&types[]=TSK
Instead of tags[]=Swagger.

@maxceem
Copy link
Contributor

maxceem commented Dec 9, 2020

in this case, when a user clicks on any of the challenge tags, the url should be (example user clicks on tag swagger)
https://staging-community-app.topcoder.com/challenges?search=swagger&tracks[DS]=true&tracks[Des]=true&tracks[Dev]=true&tracks[QA]=true&types[]=CH&types[]=F2F&types[]=TSK
Instead of tags[]=Swagger.

Great catch @SathyaJayabal.

We should apply tag in URL as search=<tag> instead of tags[]=<tag>. When we are clicking any tag on the challenge details page:

image

or in the challenge listing page:

image

This is because since recent changes, searching by tag should be done using a search field:

image

@SathyaJayabal
Copy link
Collaborator

Note, final fixes are now done for items 1-8.

@maxceem , I dont see #3 in the final fixes
We still have sub communities filter for Open for review bucket
Screenshot 2020-12-09 at 10 31 54 PM

@maxceem
Copy link
Contributor

maxceem commented Dec 9, 2020

Thanks, @SathyaJayabal. Will ensure it's fixed with other issues that are left.

@luizrrodrigues
Copy link
Collaborator

@maxceem I'll use Stag env to deploy a new feature, please let me know when ready to redeploy this one.

@SathyaJayabal
Copy link
Collaborator

@maxceem I'll use Stag env to deploy a new feature, please let me know when ready to redeploy this one.

@luizrrodrigues , not completed qa yet on this deployment. But we will complete it along with the rest of the fixes.

nqviet added a commit to nqviet/community-app that referenced this issue Dec 10, 2020
…opcoder-platform#5068#issuecomment-741600474, topcoder-platform#5068#issuecomment-741596441 and hide the sub-community select box for the review bucket
@maxceem
Copy link
Contributor

maxceem commented Dec 13, 2020

@SathyaJayabal @luizrrodrigues

All fixes are done now and pushed to the feature/filter-update branch:

@SathyaJayabal
Copy link
Collaborator

@maxceem , everything is good except for the "Specification Review" text overlap
Screenshot 2020-12-14 at 1 37 17 PM

@maxceem
Copy link
Contributor

maxceem commented Dec 14, 2020

@SathyaJayabal fixed and pushed to feature/filter-update branch:

image

@SathyaJayabal
Copy link
Collaborator

Thanks @maxceem

@luizrrodrigues luizrrodrigues added this to the v1.6.5 milestone Dec 14, 2020
luizrrodrigues added a commit to topcoder-platform/topcoder-react-lib that referenced this issue Dec 15, 2020
sushilshinde added a commit that referenced this issue Dec 15, 2020
-------------------------------------
2020/12/15 - RELEASE v1.7.0
-------------------------------------
Milestone: https://github.com/topcoder-platform/community-app/milestone/88 
community-app
Issues: #5249 #5068
PR: #5257 
DEPENDENCY: topcoder-react-lib
Release: 1.1.4
Issue: #5068
PR: topcoder-platform/topcoder-react-lib#290
@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Dec 15, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-12-15 at 2 45 04 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Challenge Listing New feature P2 Important (resolve within 3 days) QA Pass in PROD Passed verification on Production
Projects
None yet
Development

No branches or pull requests

6 participants