fix(challenge-listing): date filters will use correct query params #5039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizrrodrigues
requested review from
luizrrodrigues
and removed request for
sushilshinde and
ajefts
* The date filters at challenge listing page was using `startDateStart` (start date) and `endDateEnd` (end date) query parameters for `GET /challenges` call. * It now uses `startDateEnd` (end date) and `endDateStart` (start date) instead, in compliance with previous implementation. Addresses topcoder-platform#4984
luizrrodrigues
approved these changes
Oct 8, 2020
luizrrodrigues
merged commit 978b98f
into
topcoder-platform:feature-refactor-challengelist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
startDateStart(start date) andendDateEnd(end date)query parameters for
GET /challengescall.startDateEnd(end date) andendDateStart(start date)instead, in compliance with previous implementation.
Addresses #4984