fix(challenge-listing): date filters will use correct query params

* The date filters at challenge listing page was using `startDateStart`
and `endDateEnd` query parameters for `GET /challenges` call.
* It now uses `registrationStartDateStart` and `submissionEndDateEnd`
instead, in  compliance with previous implementation.

Addresses #4984

Author: cagdas001

src/shared/components/challenge-listing/Filters/ChallengeFilters.jsx

@@ -47,7 +47,9 @@ export default function ChallengeFilters({
   if (filterState.groups && filterState.groups.length) filterRulesCount += 1;
   if (filterState.tags && filterState.tags.length) filterRulesCount += 1;
   if (filterState.types && filterState.types.length) filterRulesCount += 1;
-  if (filterState.endDateEnd || filterState.startDateStart) filterRulesCount += 1;
+  if (filterState.submissionEndDateEnd || filterState.registrationStartDateStart) {
+    filterRulesCount += 1;
+  }
   if (isReviewOpportunitiesBucket && filterState.reviewOpportunityType) filterRulesCount += 1;
   if (selectedCommunityId !== '' && selectedCommunityId !== 'All') filterRulesCount += 1;
   const isTrackOn = track => filterState.tracks[track];

src/shared/components/challenge-listing/Filters/FiltersPanel/index.jsx

@@ -311,14 +311,21 @@ export default function FiltersPanel({
             </label>
             <DateRangePicker
               numberOfMonths={1}
-              endDate={filterState.endDateEnd && moment(filterState.endDateEnd)}
+              endDate={filterState.submissionEndDateEnd && moment(filterState.submissionEndDateEnd)}
               id="date-range-picker-one-month"
               onDatesChange={(dates) => {
                 const d = dates.endDate ? dates.endDate.toISOString() : null;
                 const s = dates.startDate ? dates.startDate.toISOString() : null;
-                setFilterState({ ..._.clone(filterState), startDateStart: s, endDateEnd: d });
+                setFilterState({
+                  ..._.clone(filterState),
+                  registrationStartDateStart: s,
+                  submissionEndDateEnd: d,
+                });
               }}
-              startDate={filterState.startDateStart && moment(filterState.startDateStart)}
+              startDate={
+                filterState.registrationStartDateStart
+                  && moment(filterState.registrationStartDateStart)
+              }
             />
           </div>
           <div styleName="filter dates hideonemonthdatepicker">
@@ -328,15 +335,20 @@ export default function FiltersPanel({
             </label>
             <DateRangePicker
               numberOfMonths={2}
-              endDate={filterState.endDateEnd && moment(filterState.endDateEnd)}
+              endDate={filterState.submissionEndDateEnd && moment(filterState.submissionEndDateEnd)}
               id="date-range-picker-two-months"
               onDatesChange={(dates) => {
                 const d = dates.endDate ? dates.endDate.toISOString() : null;
                 const s = dates.startDate ? dates.startDate.toISOString() : null;
-                setFilterState({ ..._.clone(filterState), startDateStart: s, endDateEnd: d });
+                setFilterState({
+                  ..._.clone(filterState),
+                  registrationStartDateStart: s,
+                  submissionEndDateEnd: d,
+                });
               }}
               startDate={
-                filterState.startDateStart && moment(filterState.startDateStart)
+                filterState.registrationStartDateStart
+                  && moment(filterState.registrationStartDateStart)
               }
             />
           </div>
@@ -358,8 +370,8 @@ export default function FiltersPanel({
               tags: [],
               types: [],
               groups: [],
-              startDateStart: null,
-              endDateEnd: null,
+              registrationStartDateStart: null,
+              submissionEndDateEnd: null,
             });
             selectCommunity(defaultCommunityId);
             setSearchText('');

src/shared/reducers/challenge-listing/index.js

@@ -401,19 +401,19 @@ function onSetFilter(state, { payload }) {
    * do it very carefuly (many params are not validated). */
   const filter = _.pickBy(_.pick(
     payload,
-    ['tags', 'types', 'name', 'startDateStart', 'endDateEnd', 'groups'],
+    ['tags', 'types', 'name', 'registrationStartDateStart', 'submissionEndDateEnd', 'groups'],
   ), value => (!_.isArray(value) && value && value !== '') || (_.isArray(value) && value.length > 0));
   // if (_.isPlainObject(filter.tags)) {
   //   filter.tags = _.values(filter.tags);
   // }
   // if (_.isPlainObject(filter.subtracks)) {
   //   filter.subtracks = _.values(filter.subtracks);
   // }
-  if (filter.startDateStart && !moment(filter.startDateStart).isValid()) {
-    delete filter.startDateStart;
+  if (filter.registrationStartDateStart && !moment(filter.registrationStartDateStart).isValid()) {
+    delete filter.registrationStartDateStart;
   }
-  if (filter.endDateEnd && !moment(filter.endDateEnd).isValid()) {
-    delete filter.endDateEnd;
+  if (filter.submissionEndDateEnd && !moment(filter.submissionEndDateEnd).isValid()) {
+    delete filter.submissionEndDateEnd;
   }
   // console.log(`aaaaa`);
   // console.log(filter);
@@ -810,8 +810,8 @@ function create(initialState) {
       tags: [],
       types: [],
       groups: [],
-      startDateStart: null,
-      endDateEnd: null,
+      registrationStartDateStart: null,
+      submissionEndDateEnd: null,
     },
 
     selectedCommunityId: 'All',

src/shared/utils/challenge-listing/buckets.js

@@ -172,8 +172,8 @@ export function filterChanged(filter, prevFilter) {
   || (filter.tracks.DS !== prevFilter.tracks.DS)
   || (filter.tracks.QA !== prevFilter.tracks.QA)
   || (filter.name !== prevFilter.name)
-  || (filter.startDateStart !== prevFilter.startDateStart)
-  || (filter.endDateEnd !== prevFilter.endDateEnd)
+  || (filter.registrationStartDateStart !== prevFilter.registrationStartDateStart)
+  || (filter.submissionEndDateEnd !== prevFilter.submissionEndDateEnd)
   // eslint-disable-next-line max-len
   || (filter.groups.length !== prevFilter.groups.length || filter.groups[0] !== prevFilter.groups[0])
   || _.filter(filter.tags, val => _.indexOf(prevFilter.tags, val) < 0).length > 0
@@ -202,8 +202,8 @@ export function isFilterEmpty(filter) {
     tags: [],
     types: [],
     groups: [],
-    startDateStart: null,
-    endDateEnd: null,
+    registrationStartDateStart: null,
+    submissionEndDateEnd: null,
   });
 }