Issue 329

[shubhendusaurabh]

fixed #329 escape query text for searching

[birdofpreyru]

@shubhendusaurabh I don't like the points where you do encoding / decoding. I believe, the best point to encode is https://github.com/topcoder-platform/community-app/blob/develop/src/shared/reducers/challenge-listing/index.js#L168, and the best point to decode is https://github.com/topcoder-platform/community-app/blob/develop/src/shared/reducers/challenge-listing/index.js#L272 this way it will automatically work in all other code dealing with search by text. Please update and test

[shubhendusaurabh]

@birdofpreyru Is the challenges page on latest develop branch broken? It was working yesterday.

[twicoder]

@shubhendusaurabh I will fix it

[twicoder]

@birdofpreyru Please check PR #421 for the update of issue 212.

[birdofpreyru]

@shubhendusaurabh Sorry, will have to reject this and close the original issue. The problem was fixed by a change done elsewhere. The trick, actually, was in adding the proper option { encodeValuesOnly: true } here: https://github.com/topcoder-platform/community-app/blob/develop/src/shared/utils/url.js#L31

Before it was naively configured to not encode params written to query, which caused this problem (just leaving stringify with default options is also not that good, as it replaces square brackets [..] in filter elements, which makes it more difficult to understand the query).