Skip to content

Clearing search and search using empty field won't remove the previous search term from the URL #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Aug 26, 2017 · 2 comments
Assignees

Comments

@sdgun
Copy link
Collaborator

sdgun commented Aug 26, 2017

Steps to Reproduce

Actual Result(s)

Expected Result(s)

Environment

  • Device(s): Laptop
  • Operating System: Windows 7 64bit
  • Browser(s): Chrome 60.0.3112.101 (Official Build) (64-bit)

Image/Video/JS Log/Console Log (If not attached here, Please check the comments section)

@sdgun
Copy link
Collaborator Author

sdgun commented Aug 26, 2017

63

@birdofpreyru
Copy link
Collaborator

Accepted, 3 points.
The actual problem here is that when search text is appended to URL special characters are not escaped. As in this example he used & in the search string, once it gets to URL, it is treated as params separator, and when filters reseted only known query params are removed, so this string is considered as a bunch of unknown params, and is not removed. We should properly escape the search string, and ensure that search still works properly once it is read from URL.

@birdofpreyru birdofpreyru changed the title Clearing search and search using empty field won't remove the previous search term from the URL [$20] - Clearing search and search using empty field won't remove the previous search term from the URL Aug 26, 2017
@shubhendusaurabh shubhendusaurabh self-assigned this Aug 26, 2017
shubhendusaurabh added a commit to shubhendusaurabh/community-app that referenced this issue Aug 26, 2017
@birdofpreyru birdofpreyru changed the title [$20] - Clearing search and search using empty field won't remove the previous search term from the URL Clearing search and search using empty field won't remove the previous search term from the URL Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants