Skip to content

fixed #257 corrected download link for design submission download #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2017
Merged

fixed #257 corrected download link for design submission download #316

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2504575
fixed #257 corrected download link for design submission download
shubhendusaurabh Aug 25, 2017
94f09a9
corrected download link for dev challenges
shubhendusaurabh Aug 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/shared/components/challenge-detail/Winners/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ export default function Winners(props) {
<a
styleName="download"
target="_blank"
href={w.submissionDownloadLink}
href={`${config.URL.STUDIO}/` +
`?module=DownloadSubmission&sbmid=${submissionId}`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhendusaurabh The new links seems to work fine for design challenges, but does not work for development ones. I guess, you should update it to use original link for dev challenges, and the last one for design. Also, you should not use + to concatentate strings (it actually should cause a ESLint error).

>Download</a>
}
<div styleName="date">
Expand Down