fixed #257 corrected download link for design submission download #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,7 +78,8 @@ export default function Winners(props) { | |||
| <a | |||
| styleName="download" | |||
| target="_blank" | |||
| href={w.submissionDownloadLink} | |||
| href={`${config.URL.STUDIO}/` + | |||
| `?module=DownloadSubmission&sbmid=${submissionId}`} | |||
There was a problem hiding this comment.
@shubhendusaurabh The new links seems to work fine for design challenges, but does not work for development ones. I guess, you should update it to use original link for dev challenges, and the last one for design. Also, you should not use + to concatentate strings (it actually should cause a ESLint error).
|
@birdofpreyru updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #257 corrected download link for design submission download