Skip to content

fix for #2846 #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2019
Merged

fix for #2846 #2998

merged 3 commits into from
Jul 28, 2019

Conversation

anonymousjaggu
Copy link
Collaborator

@codeMinter codeMinter self-assigned this Jul 25, 2019
@sumitdaga
Copy link
Contributor

@anonymousjaggu there is no color $tc-dark-blue-120 in the tc pallete https://marvelapp.com/c7h2a6h/screen/59648056/handoff

@codeMinter
Copy link
Contributor

codeMinter commented Jul 25, 2019 •
edited
Loading

@anonymousjaggu ‌Topcoder terms of use still fails AA. Also we will need to fix react-ui to use right code from palette shared above. Kindly raise PR for react-ui too. We cannot mix PRs of different issues together. You should have your own PR for react-ui.

@anonymousjaggu
Copy link
Collaborator Author

@codeMinter updated MR please check

@sushilshinde sushilshinde merged commit 6be61ca into topcoder-platform:qa-accessibility Jul 28, 2019
sushilshinde added a commit that referenced this pull request Jul 29, 2019
@sushilshinde
Merge pull request #2998 from anonymousjaggu/fix-2846
a42736b 
fix for #2846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajefts ajefts Awaiting requested review from ajefts ajefts is a code owner

@sushilshinde sushilshinde Awaiting requested review from sushilshinde sushilshinde is a code owner

Assignees

@codeMinter codeMinter

Labels
Accessibility Merged for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anonymousjaggu @sumitdaga @codeMinter @sushilshinde @crazyk07 @agrawal-prateek