Skip to content

MSFT-17 & MSFT-35 #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2019
Merged

MSFT-17 & MSFT-35 #2937

merged 1 commit into from
Jul 25, 2019

Conversation

r0hit-gupta
Copy link
Collaborator

@r0hit-gupta r0hit-gupta commented Jul 18, 2019 •
edited
Loading

changes for #2741 & #2757

@r0hit-gupta r0hit-gupta changed the title MSFT-17 MSFT-17 & MSFT-35 Jul 18, 2019
@anonymousjaggu anonymousjaggu self-assigned this Jul 23, 2019
@sushilshinde
Copy link
Collaborator

sushilshinde commented Jul 25, 2019 •
edited
Loading

changes for #2741 & #2757

@veshu @r0hit-gupta @anonymousjaggu Please create separate PRs and close this one

@veshu
Copy link
Contributor

veshu commented Jul 25, 2019

@sushilshinde If there one line fix, separate PR won't be helpful?

@sushilshinde
Copy link
Collaborator

@sushilshinde If there one line fix, separate PR won't be helpful?

So there two issues for the same change?

@veshu
Copy link
Contributor

veshu commented Jul 25, 2019

So there two issues for the same change?

Yes, there are few issues which are fixed with same code.

@sushilshinde sushilshinde merged commit 7d035cd into topcoder-platform:qa-accessibility Jul 25, 2019
sushilshinde added a commit that referenced this pull request Jul 28, 2019
@sushilshinde
Merge pull request #2937 from r0hit-gupta/msft17
b775629 
MSFT-17 & MSFT-35
sushilshinde added a commit that referenced this pull request Jul 28, 2019
@sushilshinde
#2757 #2937
fdb4ef8
sushilshinde added a commit that referenced this pull request Jul 29, 2019
@sushilshinde
Merge pull request #2937 from r0hit-gupta/msft17
8a02238 
MSFT-17 & MSFT-35
sushilshinde added a commit that referenced this pull request Jul 29, 2019
@sushilshinde
Merge pull request #2937 from r0hit-gupta/msft17
d6636d3 
MSFT-17 & MSFT-35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajefts ajefts Awaiting requested review from ajefts ajefts is a code owner

@sushilshinde sushilshinde Awaiting requested review from sushilshinde sushilshinde is a code owner

Assignees

@anonymousjaggu anonymousjaggu

Labels
Merged for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r0hit-gupta @sushilshinde @veshu @anonymousjaggu