Skip to content

Issue 2873 fix #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 28, 2019
Merged

Issue 2873 fix #2933

merged 11 commits into from
Jul 28, 2019

Conversation

PrakashDurlabhji
Copy link
Contributor

@PrakashDurlabhji PrakashDurlabhji commented Jul 18, 2019 •
edited by codeMinter
Loading

Issue #2873

This was referenced Jul 18, 2019
Closed
Closed
@codeMinter codeMinter assigned codeMinter and unassigned codeMinter Jul 23, 2019
@codeMinter
Copy link
Contributor

codeMinter commented Jul 23, 2019 •
edited
Loading

@PrakashDurlabhji we cannot change eslintrc - also resolve branch conflicts. You should fix your code to resolve lint issues.

@PrakashDurlabhji
Copy link
Contributor Author

@codeMinter means we cannot touch eslintrc at all?

@veshu
Copy link
Contributor

veshu commented Jul 25, 2019

@codeMinter ☝️

@codeMinter
Copy link
Contributor

@codeMinter means we cannot touch eslintrc at all?

Yes no changes to lint.

@codeMinter
Copy link
Contributor

@PrakashDurlabhji Also do not remove Code Failed label unless you have updated PR.

@veshu
Copy link
Contributor

veshu commented Jul 25, 2019

@PrakashDurlabhji Please update on this as soon as early. Thanks!

@PrakashDurlabhji
Copy link
Contributor Author

@codeMinter PR updated

@PrakashDurlabhji
Copy link
Contributor Author

@codeMinter PR updated

@codeMinter codeMinter self-assigned this Jul 27, 2019
@sushilshinde sushilshinde merged commit ec58d99 into topcoder-platform:qa-accessibility Jul 28, 2019
sushilshinde added a commit that referenced this pull request Jul 30, 2019
@sushilshinde
Merge pull request #2933 from PrakashDurlabhji/issue_2873
3f3030f 
Issue 2873 fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajefts ajefts Awaiting requested review from ajefts ajefts is a code owner

@sushilshinde sushilshinde Awaiting requested review from sushilshinde sushilshinde is a code owner

Assignees

@codeMinter codeMinter

Labels
Accessibility Merged for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PrakashDurlabhji @codeMinter @veshu @sushilshinde @crazyk07 @agrawal-prateek