Skip to content

[$60] Clicking on Challenge type tag from challenge details throws a blank page #5050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Oct 5, 2020 · 15 comments
Closed

[$60] Clicking on Challenge type tag from challenge details throws a blank page #5050

SathyaJayabal opened this issue Oct 5, 2020 · 15 comments
Assignees
@gets0ul
Labels
Challenge Details Screen Challenge Listing listing:re-implementation P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid
Milestone
v1.3.1

Comments

@SathyaJayabal
Copy link
Collaborator

Go to challenge details page
Click on challenge type tag below the title
actual: blank page is displayed
expected: listings page filtered by challenge type.
Screenshot 2020-10-05 at 3 20 22 PM
filterbytype.mov.zip
@SathyaJayabal
Copy link
Collaborator Author

Same issue when clicking on any tech tag form challenge details page.

@Oanh-and-only-Oanh Oanh-and-only-Oanh added P1 Urgent (resolve within 24 hours) and removed P0 Critical (resolve within 4 hours) labels Oct 5, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Clicking on Challenge type tag from challenge details throws a blank page [$60] Clicking on Challenge type tag from challenge details throws a blank page Oct 5, 2020
@crazyk07
Copy link

crazyk07 commented Oct 5, 2020

Contest https://www.topcoder.com/challenges/30144557 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 6-8 hours and PR to
https://github.com/topcoder-platform/community-app/tree/listing-develop-sync

https://github.com/topcoder-platform/topcoder-react-lib/tree/listing-develop-sync

run npm run test before PR

@gets0ul gets0ul self-assigned this Oct 5, 2020
@crazyk07
Copy link

crazyk07 commented Oct 5, 2020

Contest https://www.topcoder.com/challenges/30144557 has been updated - it has been assigned to gets0ul.

This is an automated message for crazyk via Topcoder X

gets0ul added a commit to gets0ul/community-app that referenced this issue Oct 6, 2020
@gets0ul
fix: issue topcoder-platform#5050
1fb7677 
Fix blank page issue when filtering challenge listing by clicking on challenge type tag below the title in challenge detail page.
@gets0ul gets0ul mentioned this issue Oct 6, 2020
Merged
luizrrodrigues added a commit that referenced this issue Oct 6, 2020
@luizrrodrigues
Merge pull request #5058 from gets0ul/issue-5050
6ba93d9 
fix: issue #5050
@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues @gets0ul , clicking on the challenge type tag or tech tag does not reset previous tag.
please see comparison video with prod
prod.mov.zip

newlistings.mov.zip

@gets0ul
Copy link
Collaborator

gets0ul commented Oct 7, 2020

@luizrrodrigues @SathyaJayabal should we reset or not, please confirm? Thanks

@SathyaJayabal
Copy link
Collaborator Author

@gets0ul , it should be same as in prod, should be reset.

gets0ul added a commit to gets0ul/community-app that referenced this issue Oct 7, 2020
@gets0ul
fix: update for issue topcoder-platform#5050
5210a03 
Reset previous type/tag filter when clicking type/tag in challenge detail page.
@gets0ul gets0ul mentioned this issue Oct 7, 2020
Merged
@luizrrodrigues
Copy link
Collaborator

@gets0ul I'm still see this issue:

  • Click in a challenge;
  • Click in challenge type;
  • Now click in a tag from any challenge;
  • Note, type not reset

https://i.gyazo.com/8230b090278a0b2d2797b63b7c4e40b5.mp4

@gets0ul
Copy link
Collaborator

gets0ul commented Oct 7, 2020 •
edited
Loading

@luizrrodrigues that was a different case. This is about when clicking the type or tag below the title in challenge detail page.
See the videos made by @SathyaJayabal in #5050 (comment)

  • Click in a challenge;
  • Click in challenge type;
  • Now click back the challenge;
  • Click in challenge tag
  • Note, type filter is now reset, replaced by tags filter

@luizrrodrigues
Copy link
Collaborator

@gets0ul Yes, flow via details page working well.

We need same way if click in tags in Listing page.

Please check Prod: https://www.topcoder.com/challenges

gets0ul added a commit to gets0ul/community-app that referenced this issue Oct 7, 2020
@gets0ul
fix: update for issue topcoder-platform#5050
25f8289 
also reset filter if tag clicked in listing page.
@gets0ul
Copy link
Collaborator

gets0ul commented Oct 7, 2020

@luizrrodrigues New commit is added. Now it will reset.

luizrrodrigues added a commit that referenced this issue Oct 13, 2020
@luizrrodrigues
Merge pull request #5066 from gets0ul/issue-5050_fix
e787563 
fix: update for issue #5050
@SathyaJayabal
Copy link
Collaborator Author

verified on staging.
5050.mov.zip

@SathyaJayabal SathyaJayabal added this to the v1.3.1 milestone Oct 13, 2020
@luizrrodrigues luizrrodrigues mentioned this issue Oct 13, 2020
Merged
@SathyaJayabal
Copy link
Collaborator Author

verified on staging (develop)
5050_Staging.mov.zip

@luizrrodrigues luizrrodrigues mentioned this issue Oct 13, 2020
Merged
@SathyaJayabal SathyaJayabal added tcx_FixAccepted QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Oct 13, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on prod
5050.mov 2.zip

@luizrrodrigues
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30144557

This is an automated message for luizrrodrigues via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gets0ul gets0ul

Labels
Challenge Details Screen Challenge Listing listing:re-implementation P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Milestone
v1.3.1
Development

No branches or pull requests
5 participants
@gets0ul @luizrrodrigues @crazyk07 @Oanh-and-only-Oanh @SathyaJayabal