Skip to content

Commit 5210a03

Browse files
committed
fix: update for issue topcoder-platform#5050
Reset previous type/tag filter when clicking type/tag in challenge detail page.
1 parent 381aac7 commit 5210a03

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/shared/components/challenge-detail/Header/ChallengeTags.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export default function ChallengeTags(props) {
6666
setImmediate(() => setChallengeListingFilter({ types: [challengeType.abbreviation] }))
6767
)
6868
}
69-
to={`${challengesUrl}?filter[types][0]=${encodeURIComponent(challengeType.abbreviation)}`}
69+
to={`${challengesUrl}?types[]=${encodeURIComponent(challengeType.abbreviation)}`}
7070
>
7171
{challengeType.name}
7272
</TrackTag>
@@ -90,7 +90,7 @@ export default function ChallengeTags(props) {
9090
key={tag}
9191
onClick={() => setImmediate(() => setChallengeListingFilter({ tags: [tag] }))
9292
}
93-
to={`${challengesUrl}?filter[tags][0]=${
93+
to={`${challengesUrl}?tags[]=${
9494
encodeURIComponent(tag)}`}
9595
>
9696
{tag}

src/shared/containers/challenge-detail/index.jsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -878,8 +878,9 @@ const mapDispatchToProps = (dispatch) => {
878878
setChallengeListingFilter: (filter) => {
879879
const cl = challengeListingActions.challengeListing;
880880
const cls = challengeListingSidebarActions.challengeListing.sidebar;
881-
dispatch(cl.setFilter(filter));
881+
const newFilter = _.assign({}, { types: [], tags: [] }, filter);
882882
dispatch(cls.selectBucket(BUCKETS.ALL));
883+
dispatch(cl.setFilter(newFilter));
883884
},
884885
setSpecsTabState: state => dispatch(pageActions.page.challengeDetails.setSpecsTabState(state)),
885886
unregisterFromChallenge: (auth, challengeId) => {

0 commit comments

Comments
 (0)