[$80] All SRM challenges are not listed

[luizrrodrigues]

1. Open the application and login as TonyJ
2. Go to https://www.topcoder.com/members/tourist/details/?track=DATA_SCIENCE&subTrack=SRM&tab=Past%20srm
3. Click Past SRM

Actual: All SRM challenges are not listed

Expected: Should show all 269 challenges

Reproducibility Rate: 3/3

Environment: HP Pavilion x360 14 inch; Windows 10 | Browser: Google Chrome 73.0.3683.75

Context: The work should be done against branch hot-fix-srm-data

IMPORTANT: See full details in original issue: #2213

[crazyk07]

Contest https://www.topcoder.com/challenges/30141020 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

[crazyk07]

Contest https://www.topcoder.com/challenges/30141020 has been updated - it has been assigned to cagdas001.

This is an automated message for crazyk via Topcoder X

[luizrrodrigues]

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/milestone-20200917
https://github.com/topcoder-platform/topcoder-react-lib/tree/milestone-20200917

run npm run test before PR

[luizrrodrigues]

@cagdas001 Thanks for join on this.

Please make sure to see whole history here: #2213

[cagdas001]

@luizrrodrigues it calls old APIs, will they be replaced by V5?

[luizrrodrigues]

@cagdas001 Yes, if not available in v5, please let me know.

[luizrrodrigues]

@cagdas001 Any progress on this?

[cagdas001]

The code looks at these fields:

const roundId = challenge.rounds.length ? challenge.rounds[0].id : 0;
const codingEndAt = challenge.rounds.length ? challenge.rounds[0].codingEndAt : '2000-01-01T00:00:00.000Z';
const finalPoints = _.get(challenge.rounds, '0.userSRMDetails.finalPoints') || 0;
const division = _.get(challenge.rounds, '0.userSRMDetails.division') || 0;
const divisionPlacement = _.get(challenge.rounds, '0.userSRMDetails.divisionPlacement') || 0;
const roomPlacement = _.get(challenge.rounds, '0.userSRMDetails.roomPlacement') || 0;
...

The current call:
https://api.topcoder.com/v4/members/tourist/srms/?filter=status%3Dpast%26isRatedForSRM%3Dtrue&limit=36&offset=0

which returns

...
            {
                "id": 17420,
                "name": "TCO19 SRM 752",
                "type": null,
                "status": "PAST",
                "startDate": "2019-03-04T13:54:00.000Z",
                "endDate": "2019-03-04T13:54:00.000Z",
                "track": "DATA_SCIENCE",
                "subTrack": "SRM",
                "numRegistrants": [
                    349
                ],
                "userIds": [...],
                "handles": null,
                "rounds": [
                    {
                        "id": 17420,
                        "registrationStartAt": "2019-03-05T12:00:00.000Z",
                        "registrationEndAt": "2019-03-06T11:55:00.000Z",
                        "codingStartAt": "2019-03-06T12:00:00.000Z",
                        "codingEndAt": "2019-03-06T13:15:00.000Z",
                        "systemTestStartAt": "2019-03-06T13:35:00.000Z",
                        "systemTestEndAt": "2019-03-06T13:35:00.000Z",
                        "status": "PAST",
                        "forumId": null
                    }
                ]
            },
...

doesn't have userSRMDetails that contains all these necessary information like score placement etc

V5 equivalent of this call:
https://api.topcoder.com/v5/members/tourist/stats/history which doesnt return some necessary fields too.

        "DATA_SCIENCE": {
            "SRM": {
                "history": [
                    {
                        "challengeId": 10709,
                        "challengeName": "SRM 352",
                        "date": 1180742400000,
                        "rating": 1867,
                        "placement": 387,
                        "percentile": 92.9904
                    },
            ...

Score, divison, room are the missing fields in V5. Not sure if percentile is the score, if so, then the missing fields are division, room

[luizrrodrigues]

Thanks @cagdas001 , let me check with API team.

[luizrrodrigues]

@urwithat Can we add more details/field to history:
https://api.topcoder.com/v5/members/tourist/stats/history

to match with v4 api:
https://api.topcoder.com/v4/members/tourist/srms/?filter=status%3Dpast%26isRatedForSRM%3Dtrue&limit=36&offset=0

[Oanh-and-only-Oanh]

@cagdas001, please provide status update.

[cagdas001]

@cagdas001, please provide status update.

any update? @luizrrodrigues @urwithat

[luizrrodrigues]

@Oanh-and-only-Oanh We need help with member-aip here. #4875 (comment)

[urwithat]

@cagdas001, @luizrrodrigues -

Would not suggest using "https://api.topcoder.com/v5/members/tourist/stats/history" as an alternative to "https://api.topcoder.com/v4/members/tourist/srms/?filter=status%3Dpast%26isRatedForSRM%3Dtrue&limit=36&offset=0"
The purpose and meaning of both APIs are divergent.

@Oanh-and-only-Oanh - I'm not sure of an alternative API for this, will enquire and get back.

[mtwomey]

This should live in v5-challenge-api. I don't think it's there at present though, so we may need to stick with the older APIs until this part gets figured out. @rootelement please correct me if I've mis-stated this.

[rootelement]

@mtwomey is correct. I'll have to find what ES index houses this information and bring it over to v5.

[Oanh-and-only-Oanh]

@rootelement, how long do you think it'll take to bring it over to v5? I'm trying to understand if it's worth waiting for v5 if it's quick or if @cagdas001 should move forward with resolving it in the interim with the older apis.

[luizrrodrigues]

@cagdas001 Any update on this one?

[Oanh-and-only-Oanh]

@cagdas001, please update us.

[cagdas001]

@Oanh-and-only-Oanh waiting for update from @rootelement . See above comments

[rootelement]

We need to leave the old SRMs to the old apis for now. Please log this as tech debt on the community app. I have an issue open on the challenge-api side to do this, but this is of lower importance than the Work Manager release, so I won't get to it until later this week at the earliest.