Skip to content

Challenge Spec: Style issues #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Aug 24, 2020 · 12 comments
Closed

Challenge Spec: Style issues #4802

SathyaJayabal opened this issue Aug 24, 2020 · 12 comments
Labels
Challenge Details Screen P2 Important (resolve within 3 days) QA Pass in PROD Passed verification on Production Staging Env v5-intgration-sub-code
Milestone
v1.2.3

Comments

@SathyaJayabal
Copy link
Collaborator

A few of the styles are still not rendering correctly.
#4510 (comment)
@SathyaJayabal
Copy link
Collaborator Author

Screenshot 2020-08-24 at 4 39 48 PM

Screenshot 2020-08-24 at 4 41 07 PM

@SathyaJayabal SathyaJayabal mentioned this issue Aug 24, 2020
Closed
@Oanh-and-only-Oanh Oanh-and-only-Oanh added this to the V5 Challenge API v1.6 milestone Aug 24, 2020
@ghost ghost linked a pull request Sep 4, 2020 that will close this issue
Fix Missing Styles #4805
Merged
@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh This one looks like PR is ready, but not set to any milestone.

@fikzzzy this ready to review?

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Sep 11, 2020 via email

@luizrrodrigues luizrrodrigues modified the milestones: V5 Challenge API v1.6, By 9/17/2020 Sep 12, 2020
@luizrrodrigues luizrrodrigues assigned ghost Sep 14, 2020
@luizrrodrigues luizrrodrigues removed a link to a pull request Sep 14, 2020
Fix Missing Styles #4805
Merged
@mfikria
Copy link

mfikria commented Sep 14, 2020

@luizrrodrigues yes it should be ready to review

luizrrodrigues added a commit that referenced this issue Sep 17, 2020
@luizrrodrigues
ci: Deploy milestone-20200917 to Dev and Stag
136f997 
Issue: #4802
@sandhiyakavi
Copy link
Collaborator

  1. The Size of the Font is increased.

image

  1. The font family differs from v4.

image

  1. Indentation issue exists.

image

@sandhiyakavi sandhiyakavi added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Sep 17, 2020
@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Sep 17, 2020 •
edited
Loading

@fikzzzy, please see feedback from @sandhiyakavi above

@Oanh-and-only-Oanh Oanh-and-only-Oanh removed the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Sep 17, 2020
@ghost
Copy link

ghost commented Sep 21, 2020 •
edited by ghost
Loading

@Oanh-and-only-Oanh Fixed in #4960. but for issue number 2 the style is hardcoded in the html template so its style is replaced the original css
image

@ghost ghost added the tcx_ReadyForReview label Sep 21, 2020
@Oanh-and-only-Oanh
Copy link

@sandhiyakavi, can you confirm that BOLD and ITALICS are working?

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh Tested in local, looks good BOLD and ITALICS.

Merged for QA.

luizrrodrigues added a commit that referenced this issue Sep 24, 2020
@luizrrodrigues
ci: Deploy milestone-20200917 to QA env
a206913 
Issues: #4802 #4784
luizrrodrigues added a commit that referenced this issue Sep 24, 2020
@luizrrodrigues
ci: Deploy milestone-20200917 to QA env
41057c7 
Issues: #4784 #4802
luizrrodrigues added a commit that referenced this issue Sep 24, 2020
@luizrrodrigues
ci: Deploy milestone-20200917 to QA env
6c6df9e 
Issues #4784 #4802
@SathyaJayabal
Copy link
Collaborator Author

verified on qa
Screenshot 2020-09-24 at 12 58 36 PM

@luizrrodrigues luizrrodrigues mentioned this issue Sep 24, 2020
Merged
@SathyaJayabal
Copy link
Collaborator Author

verified on staging (develop)
Screenshot 2020-09-24 at 3 01 24 PM
Screenshot 2020-09-24 at 3 02 32 PM

@SathyaJayabal SathyaJayabal modified the milestones: By 9/17/2020, v1.2.3 Sep 24, 2020
This was referenced Sep 24, 2020
Merged
Merged
sushilshinde added a commit that referenced this issue Sep 24, 2020
@sushilshinde
fix: for release v1.2.3
c865c7c 
Issues: #4784 #4802
PR: #5000
DEPENDENCY: topcoder-react-lib
- Issue: #4784
- PR: topcoder-platform/topcoder-react-lib#258

MS - https://github.com/topcoder-platform/community-app/milestone/70
@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Sep 24, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on prod
Screenshot 2020-09-24 at 6 21 43 PM
Screenshot 2020-09-24 at 6 22 13 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Challenge Details Screen P2 Important (resolve within 3 days) QA Pass in PROD Passed verification on Production Staging Env v5-intgration-sub-code
Projects
None yet
Milestone
v1.2.3
Development

No branches or pull requests
5 participants
@luizrrodrigues @mfikria @Oanh-and-only-Oanh @sandhiyakavi @SathyaJayabal