Skip to content

[$40] Add backward compatibility for terms links #4784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Aug 19, 2020 · 36 comments
Closed

[$40] Add backward compatibility for terms links #4784

SathyaJayabal opened this issue Aug 19, 2020 · 36 comments
Assignees
@narekcat
Labels
P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid v5-intgration-sub-code
Milestone
v1.2.3

Comments

@SathyaJayabal
Copy link
Collaborator

example:
https://www.topcoder.com/challenges/terms/detail/00000
must redirect to url with new UUID
https://www.topcoder.com/challenges/terms/detail/9ef9dec4-dddb-48c9-9cce-659db68bc5ac
@SathyaJayabal SathyaJayabal added P1 Urgent (resolve within 24 hours) v5-intgration-sub-code Prod Env Environment labels Aug 19, 2020
@luizrrodrigues luizrrodrigues self-assigned this Aug 19, 2020
@luizrrodrigues
Copy link
Collaborator

@sushilshinde @rootelement

To get Terms details with legacyIdvia https://api.topcoder-dev.com/v5/terms?legacyId= need use m2m token, @rootelement is possible make this endpoint public (if no auth just return UUID will works)

@luizrrodrigues luizrrodrigues added the Need clarification Need clarification to proceed fixing the issue further label Aug 31, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added this to the By 9/17/2020 milestone Sep 4, 2020
@luizrrodrigues
Copy link
Collaborator

@rootelement Any update on this one?

@ThomasKranitsas
Copy link
Contributor

The endpoint is now public. Please try again @luizrrodrigues

@rootelement
Copy link
Contributor

Just to clarify, the endpoint is public in dev. I will schedule a prod push soon.

@luizrrodrigues
Copy link
Collaborator

@ThomasKranitsas @rootelement Looks like deploy to dev fails:

https://app.circleci.com/pipelines/github/topcoder-platform/terms-service/114/workflows/99c030e2-95f9-463f-a1df-1dd3475388c2

@rootelement
Copy link
Contributor

Did you try it? Sometimes that happens if the health check fails. See if the api works, i'll look into why that failed

@luizrrodrigues
Copy link
Collaborator

Yep, received No token provided

@ThomasKranitsas
Copy link
Contributor

@luizrrodrigues I just triggered the deployment again. Will keep you posted

@ThomasKranitsas
Copy link
Contributor

@rootelement the deployment failed again. Can you please look into this?

@rootelement
Copy link
Contributor

Deploy succeeded. Please test @luizrrodrigues

@luizrrodrigues luizrrodrigues changed the title Add backward compatibility for terms links [$40] Add backward compatibility for terms links Sep 22, 2020
@luizrrodrigues luizrrodrigues removed their assignment Sep 22, 2020
@luizrrodrigues luizrrodrigues added tcx_OpenForPickup and removed Need clarification Need clarification to proceed fixing the issue further labels Sep 22, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30143099 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/milestone-20200917
https://github.com/topcoder-platform/topcoder-react-lib/tree/milestone-20200917

run npm run test before PR

@narekcat narekcat self-assigned this Sep 22, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30143099 has been updated - it has been assigned to Narekvar90.

This is an automated message for crazyk via Topcoder X

luizrrodrigues added a commit that referenced this issue Sep 24, 2020
@luizrrodrigues
ci: Deploy milestone-20200917 to QA env
41057c7 
Issues: #4784 #4802
luizrrodrigues added a commit that referenced this issue Sep 24, 2020
@luizrrodrigues
fix: for issue #4784
0943754 
issue #4784
luizrrodrigues added a commit that referenced this issue Sep 24, 2020
@luizrrodrigues
ci: Deploy milestone-20200917 to QA env
6c6df9e 
Issues #4784 #4802
@SathyaJayabal
Copy link
Collaborator Author

verified on qa
terms.mov 2.zip

This was referenced Sep 24, 2020
Merged
Merged
luizrrodrigues added a commit to topcoder-platform/topcoder-react-lib that referenced this issue Sep 24, 2020
@luizrrodrigues
Fix: for issue #4784
b1a1c1b 
Issue: topcoder-platform/community-app#4784

Dependency: topcoder-platform/community-app#4998
luizrrodrigues added a commit that referenced this issue Sep 24, 2020
@luizrrodrigues
fix: for issue #4784
6ed893f 
Issue #4784 

Dependency: topcoder-platform/topcoder-react-lib#257
@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , when the terms url is redirected to the new url with UUID, first a blank page is displayed. On refresh the contents are displayed.
terms_issue.mov.zip

@luizrrodrigues luizrrodrigues mentioned this issue Sep 24, 2020
Merged
@SathyaJayabal
Copy link
Collaborator Author

verified on staging(develop)
terms_ver.mov.zip

@SathyaJayabal SathyaJayabal modified the milestones: By 9/17/2020, v1.2.3 Sep 24, 2020
This was referenced Sep 24, 2020
Merged
Merged
sushilshinde added a commit that referenced this issue Sep 24, 2020
@sushilshinde
fix: for release v1.2.3
c865c7c 
Issues: #4784 #4802
PR: #5000
DEPENDENCY: topcoder-react-lib
- Issue: #4784
- PR: topcoder-platform/topcoder-react-lib#258

MS - https://github.com/topcoder-platform/community-app/milestone/70
@SathyaJayabal SathyaJayabal added tcx_FixAccepted QA Pass in PROD Passed verification on Production and removed tcx_Assigned Prod Env Environment QA Pass in Staging labels Sep 24, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on prod
terms prod.mov.zip

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30143099

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@narekcat narekcat

Labels
P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid v5-intgration-sub-code
Projects
None yet
Milestone
v1.2.3
Development

No branches or pull requests
7 participants
@ThomasKranitsas @rootelement @luizrrodrigues @narekcat @crazyk07 @Oanh-and-only-Oanh @SathyaJayabal