Skip to content

Get Recommendations Challenges on challenge details page #3620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Oanh-and-only-Oanh opened this issue Jan 30, 2020 · 15 comments
Closed

Get Recommendations Challenges on challenge details page #3620

Oanh-and-only-Oanh opened this issue Jan 30, 2020 · 15 comments

Comments

@Oanh-and-only-Oanh
Copy link

Challenge spec.

Dev copilot: Veshu

Design copilot: Fajar

https://docs.google.com/document/d/1KeGUf57j9sdSft7EJt00387_JnTaifIZVXGp11ywb4c/edit?usp=sharing

additional requirements:

display up to 3 related challenges and 3 articles

If challenge is tagged with "other", do not show anything

if more than one tag is present, display related articles and challenges based on first tag

@veshu
Copy link
Contributor

veshu commented Feb 2, 2020

The challenge has been launched at https://www.topcoder.com/challenges/30114285

@SathyaJayabal
Copy link
Collaborator

The recommended challenges must not include the current challenge (the challenge that is being viewed).

Clarifications needed:

  1. Title must be left aligned to the first card. The marvel design is also not aligned. Is this the expected design?

Screenshot 2020-02-10 at 10 58 12 AM

  1. When there are less than three articles, what should be the alignment of the cards? Left aligned or center aligned?

Screenshot 2020-02-10 at 11 15 14 AM

  1. Clicking on a recommended challenge opens the challenge in the same tab. Should it open the challenge in a new tab?

@SathyaJayabal SathyaJayabal added Dev Env Need clarification Need clarification to proceed fixing the issue further QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Feb 10, 2020
@SathyaJayabal
Copy link
Collaborator

cc @Oanh-and-only-Oanh @lakshmiathreya @veshu , please see clarifications needed items in the above comment.

@TheOsch
Copy link

TheOsch commented Feb 10, 2020

Excuse me.. So what's the answer? Must we align those 2 challenges left or leave them as they are?

@veshu
Copy link
Contributor

veshu commented Feb 10, 2020

@TheOsch based on this #3565 (comment)

  1. You can move the title more to the left, to have that space removed.

  2. Should be left-aligned.

@TheOsch
Copy link

TheOsch commented Feb 10, 2020

Clear, thank you.

@TheOsch
Copy link

TheOsch commented Feb 10, 2020

And these two lines in CSS are really everything that we have to do? Cool.

@veshu
Copy link
Contributor

veshu commented Feb 10, 2020

@TheOsch Yes correct. Also please check #3565 (comment) these 3 items too

@TheOsch
Copy link

TheOsch commented Feb 10, 2020

To open contest links in a new tab? Yes, it's convenient.

@SathyaJayabal
Copy link
Collaborator

@TheOsch , please also check this comment

"The recommended challenges must not include the current challenge (the challenge that is being viewed). "
At present, the recommended challenges also includes the challenge whose detail page is being viewed. This should not be the case.

cc @veshu

@Oanh-and-only-Oanh Oanh-and-only-Oanh removed Dev Env Need clarification Need clarification to proceed fixing the issue further QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Feb 11, 2020
@SathyaJayabal
Copy link
Collaborator

#veshu, everything looks fine except for the below minor issues

  1. clicking on # of registrants should open the challenge detail page(registrants tab selected when number of reg > 0, else details tab selected) in a new tab. Currently it is opening in the same tab.
  2. Clicking on #of Subs should open the challenge detail page(submissions tab selected when number of submissions > 0, else details tab selected) in a new tab. Currently it is opening in the same tab and the details tab is selected even when submission > 0.

Screenshot 2020-02-12 at 11 27 54 AM

@SathyaJayabal SathyaJayabal added Dev Env QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Feb 12, 2020
@SathyaJayabal
Copy link
Collaborator

@veshu

  1. this is fixed.
  2. When you click on the number of submissions, it opens the challenge in the new tab(as expected) but the selected tab is details. But the selected tab of the current window is changed to submissions tab.

see video for reference.
submissions count link.mov.zip

@SathyaJayabal
Copy link
Collaborator

@veshu , verified on beta (feature branch)

Screenshot 2020-02-13 at 8 53 48 PM

@SathyaJayabal SathyaJayabal added Beta Env Environment QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Feb 13, 2020
@SathyaJayabal
Copy link
Collaborator

verified in beta
Screenshot 2020-02-17 at 10 40 39 AM

@SathyaJayabal
Copy link
Collaborator

Verified in Prod
Screenshot 2020-02-19 at 6 14 57 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants