Skip to content

Get THRIVE article recommendations in challenge details page #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajefts opened this issue Jan 14, 2020 · 14 comments
Closed

Get THRIVE article recommendations in challenge details page #3565

ajefts opened this issue Jan 14, 2020 · 14 comments

Comments

@ajefts
Copy link
Member

ajefts commented Jan 14, 2020

Challenge spec.

Dev copilot: Veshu

Design copilot: Fajar

https://docs.google.com/document/d/1KeGUf57j9sdSft7EJt00387_JnTaifIZVXGp11ywb4c/edit?usp=sharing

additional requirements:

  • display up to 3 related challenges and 3 articles

  • If challenge is tagged with "other", do not show anything

  • if more than one tag is present, display related articles and challenges based on first tag

@ajefts
Copy link
Member Author

ajefts commented Jan 14, 2020

@veshu
Copy link
Contributor

veshu commented Jan 30, 2020

The challenge for recommended article https://www.topcoder.com/challenges/30113877
There will be separate challenge for related challenges.

@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Get THRIVE article recommendations and Challenges in challenge details page Get THRIVE article recommendations in challenge details page Jan 30, 2020
veshu added a commit that referenced this issue Feb 2, 2020
@SathyaJayabal
Copy link
Collaborator

  1. Recommendations links and articles do not show up when the user clicks on other tabs in the challenge details page (Registrants, Submissions). Is this the expected behaviour? See attached video for reference.
    thrive.mov.zip

  2. Title must be left aligned to the first card. The marvel design is also not aligned. Is this the expected design?

Screenshot 2020-02-10 at 10 58 12 AM

  1. When there are less than three articles, what should be the alignment of the cards? Left aligned or center aligned?

cc @Oanh-and-only-Oanh , @veshu @lakshmiathreya

@SathyaJayabal SathyaJayabal added Dev Env Need clarification Need clarification to proceed fixing the issue further and removed Ready for QA labels Feb 10, 2020
@veshu
Copy link
Contributor

veshu commented Feb 10, 2020

1 and 3 I have confirmed that on forum to be so. @Oanh-and-only-Oanh @Dara-K please suggest your thought.

@SathyaJayabal
Copy link
Collaborator

@veshu , I don't have access to the challenge forums. Shall I consider 1 and 3 as expected ?

@Dara-K
Copy link

Dara-K commented Feb 10, 2020

Hi @SathyaJayabal

Good points!

  1. Recommended Links and Articles should stay in the header even when the user moves to any tabs : details registrants, checkpoints, etc.

  2. You can move the title more to the left, to have that space removed.

  3. Should be left-aligned.

@SathyaJayabal
Copy link
Collaborator

@Dara-K , thank you for the answers.

@veshu , I am marking this as QA fail, so that the above can be fixed.

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Need clarification Need clarification to proceed fixing the issue further labels Feb 10, 2020
@veshu
Copy link
Contributor

veshu commented Feb 10, 2020

ok getting fixed this at f2f https://www.topcoder.com/challenges/30115205

@Oanh-and-only-Oanh Oanh-and-only-Oanh removed Dev Env QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Feb 11, 2020
@SathyaJayabal
Copy link
Collaborator

@veshu, Verified on dev.

Screenshot 2020-02-12 at 11 19 57 AM

Screenshot 2020-02-12 at 11 20 10 AM

@SathyaJayabal
Copy link
Collaborator

verified on beta
Screenshot 2020-02-17 at 10 40 39 AM

@veshu , When less than three related thrive articles are present, they are not left aligned like the recommenced challenges. They expand to fill the space. See attached screenshot above for reference. Is this behaviour ok? If not I will create a new issue to fix this.

@SathyaJayabal SathyaJayabal added Beta Env Environment and removed Dev Env labels Feb 17, 2020
@veshu
Copy link
Contributor

veshu commented Feb 17, 2020

@Dara-K @Oanh-and-only-Oanh Please check if fluid card of thrive article is okay or it should be fixed width.

@Dara-K
Copy link

Dara-K commented Feb 17, 2020

@veshu @SathyaJayabal When there are less than 3 cards, I suggest to keep them left aligned (use same width as when there are 3 cards)

@SathyaJayabal
Copy link
Collaborator

verified
Screenshot 2020-02-19 at 2 24 23 PM

@SathyaJayabal
Copy link
Collaborator

Verified in prod
Screenshot 2020-02-19 at 6 14 57 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants