Merge pull request #3142 from topcoder-platform/develop

PR from dev to master


Fix for 

#2792
#2797
#2743
#2885
#2885
#2739
#2887
#2789
#2792
#2759
#2876
#2819
#2743
#2865
#2893
#2821
#2843
#2752

Author: sushilshinde

.circleci/config.yml

@@ -194,6 +194,7 @@ workflows:
                 - general-features
                 - develop-from-master-23may
                 - hot-fixes-4
+                - release-qa-accessibility
       # Production builds are exectuted only on tagged commits to the
       # master branch.
       - "build-prod":

__tests__/shared/__snapshots__/index.jsx.snap

@@ -5,6 +5,11 @@ exports[`Snapshot match 1`] = `
   <HelmetWrapper
     defer={true}
     encodeSpecialCharacters={true}
+    htmlAttributes={
+      Object {
+        "lang": "en",
+      }
+    }
   >
     <meta
       content="#FFFFFF"
@@ -34,6 +39,11 @@ exports[`Snapshot match 2`] = `
   <HelmetWrapper
     defer={true}
     encodeSpecialCharacters={true}
+    htmlAttributes={
+      Object {
+        "lang": "en",
+      }
+    }
   >
     <meta
       content="#FFFFFF"

__tests__/shared/components/ProfilePage/Skill/__snapshots__/index.jsx.snap

@@ -5,6 +5,7 @@ exports[`renders a skill correctly 1`] = `
   className="src-shared-components-ProfilePage-Skill-___styles__container___bW089"
 >
   <div
+    aria-label="Test Skill Icon"
     className="src-shared-components-ProfilePage-Skill-___styles__skill-icon___1-d49"
   >
     <FallbackIcon

__tests__/shared/components/TopcoderHeader/__snapshots__/Auth.jsx.snap

@@ -3,10 +3,6 @@
 exports[`Snapshot match 1`] = `
 <div
   className="src-shared-components-TopcoderHeader-Auth-___style__auth___3X0_r"
-  onClick={[Function]}
-  onKeyPress={null}
-  role="button"
-  tabIndex="0"
 >
   <a
     className="tc-btn-sm tc-btn-primary"
@@ -27,10 +23,6 @@ exports[`Snapshot match 1`] = `
 exports[`Snapshot match 2`] = `
 <div
   className="column src-shared-components-TopcoderHeader-Auth-___style__auth___3X0_r"
-  onClick={[Function]}
-  onKeyPress={null}
-  role="button"
-  tabIndex="0"
 >
   <a
     className="tc-btn-sm tc-btn-primary"

__tests__/shared/components/__snapshots__/TopcoderFooter.jsx.snap

@@ -5,7 +5,7 @@ exports[`Matches shallow shapshot 1`] = `
   className="src-shared-components-TopcoderFooter-___style__footer___28yQ6"
 >
   <nav>
-    <ul>
+    <ol>
       <li
         className="src-shared-components-TopcoderFooter-___style__link___3-nzm"
       >
@@ -51,13 +51,14 @@ exports[`Matches shallow shapshot 1`] = `
           TERMS
         </a>
       </li>
-    </ul>
+    </ol>
   </nav>
   <div
     className="src-shared-components-TopcoderFooter-___style__social-links___2G4Ia"
   >
     <hr />
     <a
+      aria-label="Facebook"
       href="https://www.facebook.com/topcoder"
       target="fbwindow"
     >
@@ -78,6 +79,7 @@ exports[`Matches shallow shapshot 1`] = `
       </svg>
     </a>
     <a
+      aria-label="Twitter"
       href="http://www.twitter.com/topcoder"
       target="twwindow"
     >
@@ -98,6 +100,7 @@ exports[`Matches shallow shapshot 1`] = `
       </svg>
     </a>
     <a
+      aria-label="Linkedin"
       href="https://www.linkedin.com/company/topcoder"
       target="liwindow"
     >
@@ -118,6 +121,7 @@ exports[`Matches shallow shapshot 1`] = `
       </svg>
     </a>
     <a
+      aria-label="Instagram"
       href="https://www.instagram.com/topcoder"
       target="inwindow"
     >

__tests__/shared/components/challenge-listing/Filters/__snapshots__/ChallengeFilters.jsx.snap

@@ -108,7 +108,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
     />
     <span>
       <span
+        aria-checked={false}
+        aria-label="Filter"
         className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
+        role="switch"
       >
         <ThemedSwitchWithLabel
           composeAdhocTheme="deeply"
@@ -122,7 +125,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
         />
       </span>
       <span
+        aria-checked={false}
+        aria-label="Filter"
         className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
+        role="switch"
       >
         <ThemedSwitchWithLabel
           composeAdhocTheme="deeply"
@@ -136,7 +142,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
         />
       </span>
       <span
+        aria-checked={false}
+        aria-label="Filter"
         className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
+        role="switch"
       >
         <ThemedSwitchWithLabel
           composeAdhocTheme="deeply"