Skip to content

[$20]{MSFT-86} {Challenges} - The contrast color is low for Help Icon near Review Score #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veshu opened this issue Jul 17, 2019 · 38 comments

Comments

@veshu
Copy link
Contributor

veshu commented Jul 17, 2019

Steps to Reproduce

  1. Go to https://www.topcoder.com/challenges
  2. Inspect Element
  3. Observe the color of Help Icon near "REVIEW STYLE".

Expected Result
Expected contrast ratio of 4:5:1 should be present.

Actual Result
Element has insufficient color contrast Ration 2.17:1 (foreground color: #FFFFFF, background color: #60c700)

Device: Desktop/Labtop
Operating System: macOS
Browser: Chrome

WCAG Category: 1. Perceivable
WCAG Level: AA
WCAG Success Criterion: 1.4.3 Contrast (minimum)
Screen Reader Used:
Accessibility Audit Tool used: Other

Attachment
https://topcodermsft-my.sharepoint.com/personal/pd-topcoder_topcodermsft_onmicrosoft_com/Documents/Forms/All.aspx?cid=ae14bf9a%2D590b%2D4bb4%2Da40a%2D4c6822c880a4&FolderCTID=0x0120005C598A51049FC14CBA882E1AEE168F51&id=%2Fpersonal%2Fpd%2Dtopcoder%5Ftopcodermsft%5Fonmicrosoft%5Fcom%2FDocuments%2FMSFT%2DTeams%2DQA%2FJune%202019%2F29%20Jun%2FTest%20Results%2FBug%20Videos%20%26%20Log%20Files%2FCreeya%2FBug%2086

@veshu veshu changed the title [MSFT-86] [Challenges] - The contrast color is low for Help Icon near Review Score [$10][MSFT-86] [Challenges] - The contrast color is low for Help Icon near Review Score Jul 18, 2019
@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30096087 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30096087 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@r0hit-gupta
Copy link
Collaborator

Please assign me

r0hit-gupta added a commit to r0hit-gupta/community-app that referenced this issue Jul 18, 2019
r0hit-gupta added a commit to r0hit-gupta/community-app that referenced this issue Jul 18, 2019
@r0hit-gupta r0hit-gupta mentioned this issue Jul 18, 2019
@Dara-K
Copy link

Dara-K commented Jul 20, 2019

@r0hit-gupta Please change the green color to #328732

@r0hit-gupta
Copy link
Collaborator

@Dara-K I have changed the color. Thanks.

@jmgasper jmgasper changed the title [$10][MSFT-86] [Challenges] - The contrast color is low for Help Icon near Review Score [$10]{MSFT-86} {Challenges} - The contrast color is low for Help Icon near Review Score Jul 25, 2019
@tosha5252
Copy link

There are 2 button, one overlying the other, near 'review scorecard' and they are both the incorrect color...per the comments above, the green color #328732 should be used

button_overlay

@tosha5252 tosha5252 added QA Failed on Prod Fail on Production and removed Ready for Prod QA labels Aug 8, 2019
@r0hit-gupta
Copy link
Collaborator

@tosha5252 it looks fine to me on production. Can please you try again in incognito? Thanks!

image

@tosha5252
Copy link

in incognito mode...the overlying icon disappears, but the icons are still the wrong color green...per DaraK's comment above, the color used should be #328732

wrong_color

@r0hit-gupta
Copy link
Collaborator

@r0hit-gupta Please change the green color to #328732

@Dara-K @tosha5252 this color does not exist in the palette. https://marvelapp.com/c7h2a6h/screen/59648056/handoff

I have used $tc-green-110 instead. Please let me know if it needs to be changed. Thanks!

@veshu
Copy link
Contributor Author

veshu commented Aug 8, 2019

@tosha5252 This color is accepted as we are using the same color throughout the green.

You can accept regardless earlier color in the comment.

@crazyk07
Copy link

crazyk07 commented Aug 8, 2019

@tosha5252 As long as it is the same green we are using with the other like icons, then we are fine. Be sure the tool tip works as well

@tosha5252 tosha5252 added QA Pass in PROD Passed verification on Production tcx_FixAccepted and removed QA Failed on Prod Fail on Production labels Aug 9, 2019
@tosha5252
Copy link

  1. The color green being used is acceptable
  2. The tool tips are working

Win10/Chrome

@crazyk07 crazyk07 added tcx_Paid and removed Accessibility Challenge Listing P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production labels Aug 9, 2019
@crazyk07
Copy link

crazyk07 commented Aug 9, 2019

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30097287

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests