Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

issue 196 fix #588

Merged
merged 2 commits into from
Jul 26, 2020
Merged

issue 196 fix #588

merged 2 commits into from
Jul 26, 2020

Conversation

PrakashDurlabhji
Copy link
Contributor

@PrakashDurlabhji PrakashDurlabhji commented Jul 24, 2020 •
edited by callmekatootie
Loading

@PrakashDurlabhji PrakashDurlabhji mentioned this pull request Jul 24, 2020
Closed
callmekatootie
callmekatootie suggested changes Jul 25, 2020
View reviewed changes
Copy link
Collaborator

@callmekatootie callmekatootie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing indicator loads at the center the page (on Chrome / Firefox).

The one with your fix does not load at the center - it's higher

@PrakashDurlabhji
Copy link
Contributor Author

@callmekatootie will check it again

@callmekatootie
Copy link
Collaborator

Also - don't forget to pull latest code and keep your base branch in sync

@callmekatootie callmekatootie merged commit 06246e1 into develop Jul 26, 2020
@callmekatootie callmekatootie deleted the issue_196 branch July 26, 2020 06:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@callmekatootie callmekatootie callmekatootie approved these changes

Assignees
No one assigned
Labels
tcx_Feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PrakashDurlabhji @callmekatootie