Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$10] No "No xxx found" messages for CUSTOM ATTRIBUTES #267

Closed
codejamtc opened this issue Jul 12, 2020 · 12 comments
Closed

[$10] No "No xxx found" messages for CUSTOM ATTRIBUTES #267

codejamtc opened this issue Jul 12, 2020 · 12 comments
Labels
bug Something isn't working low priority To be fixed, but could be re-prioritized.

Comments

@codejamtc
Copy link

https://take.ms/Ril5Y

Reproduction Steps:

  1. Open the Application https://skill-search.topcoder-dev.com/
  2. Click Topcoder > Go to the Tab 01
  3. Click "Add Filters" and Turn ON all the filters
  4. Enter invalid text to all the CUSTOM ATTRIBUTE filters

Actual Result: No "No xxx found" messages for CUSTOM ATTRIBUTES

Expected Result: Should display the message

Device/OS: Laptop | Windows 10 (64bit)

Browser Information: Chrome 83.0.4103.116 | Firefox 78.0.2 | IE11

@callmekatootie
Copy link
Collaborator

valid bug. Similar to #123 but for custom attribute filter

@callmekatootie
Copy link
Collaborator

Will be taken up in #123 itself

@callmekatootie callmekatootie changed the title No "No xxx found" messages for CUSTOM ATTRIBUTES [$10] No "No xxx found" messages for CUSTOM ATTRIBUTES Jul 25, 2020
@callmekatootie
Copy link
Collaborator

Did not seem to have been resolved by #123

Expected: For custom attribute filters, when there are no search results in the dropdown, display "No results found" just as you see for the Skills dropdown

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2020

Contest https://www.topcoder.com/challenges/30134278 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2020

Contest https://www.topcoder.com/challenges/30134278 has been updated - it has been assigned to rashmi73.

This is an automated message for lazybaer via Topcoder X

@callmekatootie
Copy link
Collaborator

@rashmi73 Status check - if you are not actively working on this at the moment, request you to kindly open for others to pickup

@rashmi73
Copy link
Contributor

@callmekatootie Yes I am actively and MR in sometime

@rashmi73
Copy link
Contributor

@callmekatootie here is PR #605

can you please increase prize as it was more efforts and logical. also the amount that shall be on this ticket is rather on #123 and also didnt solve it and hence i have also included skills in my PR even though it is not mentioned.

@callmekatootie
Copy link
Collaborator

callmekatootie commented Jul 26, 2020

Hey @rashmi73

You only had to copy the changes made here - https://github.com/topcoder-platform/u-bahn-app/pull/570/files - but for company attribute filters.

Also not sure what you mean by didn't solve it and included skills in your fixes - the changes from that do indeed provide the "No Results found" message for skills. I am expecting the same for company attribute filters...

image

^ Without your changes - skills dropdown works... Expecting the same, but for company attributes... You only need to copy the changes for company attributes and for that $10 sounds easy

@callmekatootie
Copy link
Collaborator

@rashmi73 Apologies but I will have to unassign you - the changes are too simple to take 8 hours to complete...

@callmekatootie
Copy link
Collaborator

This has been resolved in 0023810

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 26, 2020

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for lazybaer via Topcoder X

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working low priority To be fixed, but could be re-prioritized.
Projects
None yet
Development

No branches or pull requests

5 participants