Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

fix: issue #90 #97

Merged
merged 1 commit into from
Feb 18, 2021
Merged

fix: issue #90 #97

merged 1 commit into from
Feb 18, 2021

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Feb 14, 2021

No description provided.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution we would like to use API for loading a single Job for this by id https://github.com/topcoder-platform/taas-app/blob/dev/src/services/jobs.js#L9-L16.

In your implementation, you are using an endpoint to get the whole Team. Such an endpoint returns much more data and is slower than loading a single Job.
Also, we don't have to load Job, if resource booking doesn't have jobId. While now, you are always loading the Team data.

Though what we can change in the initial requirement is:

  • it's ok to load resource booking first, and show Loading... inside Job Name, if the job not yet loaded, and only show job name after it is loaded
  • or wait until job is loaded as was required initially
    both ways are fine.

@yoution
Copy link
Contributor Author

yoution commented Feb 17, 2021

@maxceem how can I get these info
image

from the resourcebooking api, I can not get these info

@maxceem
Copy link
Contributor

maxceem commented Feb 17, 2021

I've got you @yoution. Let's hold on a bit with this task. We would have to update the API before we can fix this task.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution I guess we cannot update API for this fast, but we need this fix asap. So we would use your approach here. Great finding of using Team endpoint for this, by the way. Thank you.

@maxceem maxceem merged commit b96c46e into topcoder-archive:dev Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants