Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

fix: issue #35 #88

Merged
merged 3 commits into from
Feb 17, 2021
Merged

fix: issue #35 #88

merged 3 commits into from
Feb 17, 2021

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Feb 13, 2021

No description provided.

@yoution yoution mentioned this pull request Feb 13, 2021
Closed
maxceem
maxceem suggested changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution thank you for taking care of singular and plural values. It works good. Though I'd like to make a couple of improvements. Please, kindly check the comments below.

@maxceem
Copy link
Contributor

maxceem commented Feb 16, 2021

Just realized one more thing @yoution we already have reusable method formatPlural to format singular/plural words. It could be used to format position(s) instead of the additional if else:

formatPlural(job.numPositions, "open position")

@yoution yoution requested a review from maxceem February 17, 2021 03:10
maxceem
maxceem approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @yoution, works perfectly now.

@maxceem
Copy link
Contributor

maxceem commented Feb 17, 2021 •
edited
Loading

@yoution this PR has some conflicts, could you please resolve them, before I can merge this. Update: resolved them myself.

@maxceem maxceem merged commit 9f52f0b into topcoder-archive:dev Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxceem maxceem maxceem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoution @maxceem