Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

fix: issue #13 #43

Closed

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Jan 6, 2021

@maxceem please reivew for #13

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution it has some issue for me.

I've added some fix to the config to be able to test locally. You may apply your changes to the branch feature/build-improvements where config is fixed, and after make the next commands to test your PR locally.

  1. If I build in production mode the styles got broken:

  2. If I build in development mode the styles got broken too:

@yoution
Copy link
Contributor Author

yoution commented Jan 19, 2021

@maxceem for APPMODE=development APPENV=dev npm run build, maybe some cache, you should disabled the cache,
I have pushed, please review #13

@maxceem
Copy link
Contributor

maxceem commented Jan 19, 2021

I have pushed, please review #13

@yoution I don't see new changes in the PR.

Did you try to run it locally? Can you please share a demo video of how it works for you? See how it works for me after I apply the fix from branch feature/build-improvements and your PR, video https://monosnap.com/file/ljk5UEeTntl9dvJp6oYluuanwvRh7V

@maxceem
Copy link
Contributor

maxceem commented Jan 19, 2021

Closing this PR as a new one was created #58

@maxceem maxceem closed this Jan 19, 2021
@yoution
Copy link
Contributor Author

yoution commented Jan 19, 2021

@maxceem #58 still not work? I change file in the webpack.js file, I will record a video

@maxceem
Copy link
Contributor

maxceem commented Jan 19, 2021

I will check #58 now, didn't check it yet.

@yoution
Copy link
Contributor Author

yoution commented Jan 19, 2021

@maxceem https://monosnap.com/file/fHzGiPGPIumKvOalNARgYy9Lz6E9l2,
sorry, I use a new branch

@maxceem
Copy link
Contributor

maxceem commented Jan 19, 2021

@yoution it seems to work good now, no need to create a video.

@yoution yoution deleted the feature/yoution-issue-13 branch June 22, 2021 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants