-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoution it has some issue for me.
I've added some fix to the config
to be able to test locally. You may apply your changes to the branch feature/build-improvements
where config is fixed, and after make the next commands to test your PR locally.
-
If I build in production mode the styles got broken:
-
build
APPMODE=production APPENV=dev npm run build
-
host the built files:
npx http-server dist -p 8501 --cors
-
styles got broken
-
-
If I build in development mode the styles got broken too:
-
build
APPMODE=development APPENV=dev npm run build
-
host the built files:
npx http-server dist -p 8501 --cors
-
styles got broken
-
@yoution I don't see new changes in the PR. Did you try to run it locally? Can you please share a demo video of how it works for you? See how it works for me after I apply the fix from branch |
Closing this PR as a new one was created #58 |
I will check #58 now, didn't check it yet. |
@maxceem https://monosnap.com/file/fHzGiPGPIumKvOalNARgYy9Lz6E9l2, |
@yoution it seems to work good now, no need to create a video. |
@maxceem please reivew for #13