-
Notifications
You must be signed in to change notification settings - Fork 24
[$100] Optimize production builds to reduce size #13
Comments
Contest https://www.topcoder.com/challenges/30160318 has been created for this ticket. |
@maxceem please assign to me |
Contest https://www.topcoder.com/challenges/30160318 has been updated - it has been assigned to yoution. |
@yoution nice catch with Meanwhile, we should still minify CSS classnames: At the moment generated classnames via CSS Modules have long names like See how it looks for Connect App or Community App: So we have to config CSS Modules to use short classnames in production mode. |
Please, work on this issue as the last one, this has small priority and other issues are more important. |
@maxceem please review |
Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30160318 |
Reopen for tracking purposes. |
QA Guide:
|
CSS and JS both are optimized. @maxceem Not able to do smoke test as the changes done in api are not reflecting in Front End. |
@maxceem Changes done in api are reflecting now in FE. Completed smoke testing. Everything is fine. |
Currently, production builds are not optimized:
We should configure webpack in such a way that
npm run build
create a minified file. Note, that this application is configured to be a microapp inside a Single SPA application, so it cannot be run as a standalone application. And it has a special custom webpack config which we can extend in https://github.com/topcoder-platform/taas-app/blob/feature/api-integration/webpack.config.js#L3.Development build should not be minified.
For minifying, we can use the same approach as our Topcoder Community App config https://github.com/topcoder-platform/topcoder-react-lib
In this task we only need to optimize the built for the TaaS App. Later we would apply the same approach for the Navbar App.
The text was updated successfully, but these errors were encountered: