Don't display a role without a global rate

[nikolay83]

Is there is a role in the database that has a global rate (the full-time one) empty or null, then this role shouldn't

• be displayed in the Roles list
• be found when searching via Skills or Job Description flow

[yoution]

@nikolay83 please review
topcoder-platform/taas-apis#479
#462

[sdgun]

@nikolay83 @wdprice Should this only be applied to Global rate (full time)? In my comment on issue 434, it's missing part time global rate which cause the amount to be displayed as 'NaN'

[wdprice]

Ah OK, so we need Global Part time rates added? That is easy enough to fix - it is a data issue.

Looks like we cannot edit the Custom Role data in the admin console, so I'll specify here:
30 hour rate = Global Rate * .75
20 hour rate = Global Rate * .5

[nikolay83]

@yoution
2 extra requirements:

1. global20 and global30 rates also shouldn't be empty or null. So display only the roles that have all 3 global rates not empty.
2. display the part-time rate for the custom role (the full-time rate is in config) as
   30 hour rate = Global Rate * .75
   20 hour rate = Global Rate * .5

[yoution]

@nikolay83 the full-time rate is in config, does it already exist?I can not found the config value

[sdgun]

@yoution The rate is set incorrectly. For 30 hrs it should be Global Rate * .75 and for 20hrs Global Rate * .5, but it is vice versa now.

2021-08-13_11-32-10.mp4

[yoution]

@sdgun I will check

[nikolay83]

@yoution
customRole.rates[0].rate20Global = customRole.rates[0].global * 0.75
customRole.rates[0].rate30Global = customRole.rates[0].global * 0.5

Should be vice versa, 0.75 for 30 hours

[yoution]

@nikolay83 please review

[sdgun]

Verified in Dev, fixed.

[sdgun]

Verified in production.