Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Deposit Confirmation Screen Display Issues #434

Closed
wdprice opened this issue Aug 9, 2021 · 8 comments
Closed

Deposit Confirmation Screen Display Issues #434

wdprice opened this issue Aug 9, 2021 · 8 comments
Assignees
Labels

Comments

@wdprice
Copy link

wdprice commented Aug 9, 2021

image

Custom role is not bringing a number to this screen - nothing is included in the total deposit for that role.

If no role image is related to the role, we need it to display the default role image.

@wdprice wdprice added the bug Something isn't working label Aug 9, 2021
@ghost
Copy link

ghost commented Aug 10, 2021

What are the steps to recreate this issue?

@wdprice
Copy link
Author

wdprice commented Aug 10, 2021

Honestly, easiest way to get a custom role is to choose a single skill in the "Input Skills" flow. Choose something that isn't a part of any role and search on it. For example, I added only a single skill: Amazon Alexa and searched.

This got me to the custom role screen. Then click on "Continue this Search" to add the custom role to your cart and proceed to the deposit.

@ghost
Copy link

ghost commented Aug 11, 2021

Fixed #441

@sdgun
Copy link

sdgun commented Aug 11, 2021

Not sure if there will be roles without rate values, but if there is no rate set, NaN is still displayed on the checkout page

image

@wdprice
Copy link
Author

wdprice commented Aug 11, 2021

We shouldn't display a role without a global rate ever.

@nikolay83
Copy link
Collaborator

@wdprice @sdgun
sounds like a new requirement, so I've created a separate issue: #462 and changed the status to Ready for QA here.

@sdgun
Copy link

sdgun commented Aug 16, 2021

Verified in production.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants