Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Move # of Resources per Role earlier in the flow #356

Closed
wdprice opened this issue Jun 30, 2021 · 16 comments
Closed

Move # of Resources per Role earlier in the flow #356

wdprice opened this issue Jun 30, 2021 · 16 comments

Comments

@wdprice
Copy link

wdprice commented Jun 30, 2021

Rather than having the customer confirm the # of resources for a role only in the last step, prompt them after they continue from the match screen to enter how many resources they need.

Keep the final screen as confirmation.

@wdprice wdprice added enhancement New feature or request Role-Matching-Intake labels Jun 30, 2021
@nikolay83
Copy link
Collaborator

@wdprice

Keep the final screen as confirmation
But still editable, right?

@wdprice
Copy link
Author

wdprice commented Jul 9, 2021

Correct

@yoution
Copy link
Contributor

yoution commented Jul 14, 2021

@nikolay83
add three input fields here?
and we can only edit the current search position?
image

@nikolay83
Copy link
Collaborator

nikolay83 commented Jul 14, 2021

@yoution

  1. Yes, here please.
  2. Yes, only the current ones. The default values must be configured, and they will be 1 resource and 4 weeks. Also these are the minimum values.

@yoution
Copy link
Contributor

yoution commented Jul 14, 2021

@nikolay83
when does the modal show?after searching the role and show the modal automatically or click the submit Requestbutton?

yoution added a commit to yoution/taas-app that referenced this issue Jul 15, 2021
nikolay83 added a commit that referenced this issue Jul 15, 2021
@nikolay83
Copy link
Collaborator

@yoution
please show the interface after the search is done. Currently this modal makes the search animation even shorter which is not desired.
Instead of the modal just add it to the march screen https://monosnap.com/file/07czrvUNuQ4jPm3q1omiI0kBqODhI0, the location is up to, e.g. beneath the match rate green circle will be fine, and "60% of members are available 20 hours / week (part time)" text will be removed anyway.

yoution added a commit to yoution/taas-app that referenced this issue Jul 16, 2021
nikolay83 added a commit that referenced this issue Jul 16, 2021
nikolay83 added a commit that referenced this issue Jul 16, 2021
@nikolay83
Copy link
Collaborator

nikolay83 commented Jul 16, 2021

@yoution

  1. If you update weeks and # resource and then continue to submit, there will still be default values (1 and 4) in the team details screen.
  2. there are unnecessary scroll bars now (Safari, MacOS BigSur)
    image

@yoution
Copy link
Contributor

yoution commented Jul 16, 2021

@nikolay83
for first one, why not update the data in the detail screen?

@nikolay83
Copy link
Collaborator

  1. Do you mean Team Details? The idea is to let the user to update the value both in the Matching screen and the Team details screen. The values set in the Matching screen must be propagated to the Team details screen.

  2. Also the "Save" button is redundant here and not clickable anyway. Please remove.

@yoution
Copy link
Contributor

yoution commented Jul 16, 2021

@nikolay83

  1. currently, if you set the value in Matching screen, it will pass to Team details screen, this logic is wrong?
    you didn't click the save button, so the values are not passed to Team details screen?
  2. I can not reproduce the scrollbar issue
    image
  3. if the validition shows error, and we remove the save button, is the continue button clickable?
    image

@nikolay83
Copy link
Collaborator

nikolay83 commented Jul 16, 2021

@yoution
1-2. I got it: user should have saved the input before she continues. That was not intuitive.
Please remove the Save button and do save the # weeks and # resources on Continue button click.
3. Please reuse validation from here #362

@yoution
Copy link
Contributor

yoution commented Jul 16, 2021

@nikolay83
how about this error reading?
image

@nikolay83
Copy link
Collaborator

nikolay83 commented Jul 16, 2021

@yoution
Actually, for # resources any message doesn't make sense, it's clear why it's not zero or -1 :) So just don't keep the existing way of validation response.
For # weeks - yes, looks good.

yoution added a commit to yoution/taas-app that referenced this issue Jul 16, 2021
nikolay83 added a commit that referenced this issue Jul 17, 2021
nikolay83 added a commit that referenced this issue Jul 17, 2021
@sdgun
Copy link

sdgun commented Jul 19, 2021

Verified in Dev, there is a validation message for resource and it has a typo.

image

@sdgun
Copy link

sdgun commented Jul 20, 2021

Created issue #390 for the above issue

@sdgun
Copy link

sdgun commented Jul 26, 2021

Verified in production.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants