Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Integrate Customer Scroll #355

Closed
wdprice opened this issue Jun 30, 2021 · 13 comments
Closed

Integrate Customer Scroll #355

wdprice opened this issue Jun 30, 2021 · 13 comments

Comments

@wdprice
Copy link

wdprice commented Jun 30, 2021

Integrate the scrolling customer feed from Topcoder.com into the app and keep it displayed at all phases. Doesn't need the same layout at Topcoder.com, but should show the same logos and instill confidence in the user.

image

@nikolay83
Copy link
Collaborator

@urwithat @wdprice
any source code to reuse?
What will be the source of the images?

@wdprice
Copy link
Author

wdprice commented Jul 14, 2021

I can check w/ marketing.

@wdprice
Copy link
Author

wdprice commented Jul 14, 2021

@nikolay83 - this is a CSS keyframe animation

#box { background-image: url('https://www.topcoder.com/wp-content/uploads/2020/12/Homepage-Logos.svg'); animation: backgroundScroll 300s linear infinite; } @keyframes backgroundScroll { from {background-position: 0 0;} to {background-position: -7701px 0;} }

Adjust the keyframe “to” values depending on the size of the image that you are going to use.

May need some tinkering, but hopefully this gets us going in the right direction.

@sdgun
Copy link

sdgun commented Jul 19, 2021

@nikolay83 I do not see the customer scroll, checked in incognito too.

@nikolay83
Copy link
Collaborator

It used to work for me, but it's gone.

@yoution
Copy link
Contributor

yoution commented Jul 19, 2021

@nikolay83 @sdgun sorry, I can not reproduce it
image

@sdgun
Copy link

sdgun commented Jul 20, 2021

@yoution I tried clearing cache and in multiple browsers but no luck

@yoution
Copy link
Contributor

yoution commented Jul 20, 2021

@sdgun @nikolay83 because the screen height is less than 859px, how to fix it?

image

@nikolay83
Copy link
Collaborator

@sdgun @urwithat
something happened to the screen height. I have to zoom out to 67% to view it normally including the ribbon with logos.

yoution added a commit to yoution/taas-app that referenced this issue Jul 21, 2021
yoution added a commit to yoution/taas-app that referenced this issue Jul 21, 2021
nikolay83 added a commit that referenced this issue Jul 21, 2021
@nikolay83
Copy link
Collaborator

@yoution
It still requires zooming out down to 75% in Safari and Chrome.

@yoution
Copy link
Contributor

yoution commented Jul 21, 2021

@nikolay83 because Baghel add a minHeight restriction, if screen height is smaller than the value, it will hide the scroll.
I don't know which screen height the scroll should support

mbaghel added a commit to mbaghel/taas-app that referenced this issue Jul 22, 2021
nikolay83 added a commit that referenced this issue Jul 22, 2021
feat: Support direct links to the Job Candidates tabs and 
issue: #355 (the Logo Ribbon and the page height)
@sdgun
Copy link

sdgun commented Jul 23, 2021

Verified in Dev in windows - Chrome/Firefox browsers and @SathyaJayabal checked in mac. Noted the customer scroll shown on top of the page when the content is still being loaded. Not reporting new issues since this feature is to be changed as per #402

image

@sdgun
Copy link

sdgun commented Jul 26, 2021

Verified in production.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants