This repository was archived by the owner on Mar 13, 2025. It is now read-only.
Adds fixes for adding and editing payments, implements WP data reloading, updates toastr positioning #99
+419
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opcoder-archive#94, topcoder-archive#95. - Adds fixes for adding and editing payments (topcoder-archive#80, topcoder-archive#82) - Adds working period data reloading after adding and editing payments (topcoder-archive#94) - Makes toastr messages always stay withing the viewport (topcoder-archive#95)
maxceem
suggested changes
Aug 14, 2021
There was a problem hiding this comment.
Thank you @MadOPcode most of the things work great. There is a couple of small improvements I'd like to make:
-
The font in the Tooltip for Additional Payment is not the same like in other tooltips, can we make it the same?
-
When we edit the payment
daysoramount, if we change value and then change back so the value is same before, the "Update" button stays enabled, though it suppose to get disabled again as there is not more changes in the form anymore, see demo video https://monosnap.com/file/3GjLOz79x6cqajFPodzVgcIf8Q4B0f
And one more thing in code below.
- Fixed tooltip font for actions' menu - Changed condition for disabling "Update" button for edit-payment modals - Changed how ActionsMenu handles "disabled" property of its items.
maxceem
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
@MadOPcode thanks, all works good as per local testing. Passing it for QA.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fixes for #80, #82. Implements #94, #95.