[$80] Additional Payments

[maxceem]

Background

At the moment we can only process payments to the resource bookings for some amount of days worked via UI https://monosnap.com/file/HOmkcBnEVYmz3j0n32CcQ25TFQmQT5.

Sometimes managers would like to process additional payments which would not be counted for days. For this purpose we would like to introduce another way to process additional payments.

Task

• Add Actions dropdown menu to each of the row in the table with 1 option: Additional Payment

  

  • The actions dropdown is already implemented in https://github.com/topcoder-platform/taas-app see demo page https://platform.topcoder-dev.com/taas/myteams/18102. Please, port it from there. Or reuse it if it was already ported during another task [$45] Edit payments #80.

• When we click Additional Payment show a modal:

  

• If we click Cancel or X just close the modal.

• if we click Process Payment show a loading indicator inside the modal or disable the field and all the buttons while sending request to the server.

  • if request was successful, show a successful green toastr and close the modal which says, Additional payment scheduled for resource:
    
  • in case of error show error red toastr with error message from the server, but keep the modal open so user can try processing payment again

• we don't have a design for this modal, please use styles of the existent modal, it can be seen like shown on this screenshot https://monosnap.com/file/vtLasCWUEocTs3CVPg4typTRYbfjVU.

• for the field use styles like in https://github.com/topcoder-platform/taas-app, see example page with such a field https://platform.topcoder-dev.com/taas/myteams/18102/rb/ac7e4dae-8a0b-468c-bb53-1b93f13cd825/edit

API

• we've updated API to support additional payments [$30] Additional Payments topcoder-platform/taas-apis#430
• to create additional payment use endpoint POST ​/work-period-payments passing in the body:

  {
   "workPeriodId": "3fa85f64-5717-4562-b3fc-2c963f66afa6", // work period id
   "days": 0, // we should ALWAYS pass 0 to indicate that this is an additional payment, not for days
   "amount": 200 // amount entered in the form
  }

[sandhiyakavi]

@maxceem Below are the issues found,

1. We are able to process Additional payment for the future weeks.
2. If we process additional payment for WP that has status 'pending', it is changing into 'partially-completed' status whereas the other status are not getting changed (No Days).

3. Similarly when the additional payment is in scheduled/in progress status, the Status of WP is getting changed to 'in-progress' for all status except 'NO DAYS' status, it is still displaying the same. So there is no way for the user to know whether the additional payment is triggered or not.

4. In the modal, if we enter floating values (even though less than 100,000) with six digits, it is showing wrong error message "Amount should be greater than 0 and less than 100,000."

[sandhiyakavi]

@maxceem some more issues,

5. In the modal, the default value is getting displayed as 0 which is not allowed (should be greater than 0).Can we make the textbox empty instead of displaying 0?
   
6. If the RB BA is not assigned, we are able to process additional payment and then read toaster message is displayed with code, is it possible to disable Additional payment option if BA not assigned as the red toastr message is not visible if the resources per page is more and the modal also is still opened which is causing confusion.
   
7. In the modal, text is missing 'the' in it . "Additional payment for Resource Booking "tester1234" for the week "08/08 - 08/14""
   

[maxceem]

Sum up:

1. Disable "Additional Payment" option for future work periods and show tooltip when we put mouse on it: Not allowed processing payments for the future weeks.

2. will be fixed server-side by [DEV] fix WP status when only have additional payments topcoder-platform/taas-apis#491

3. will be fixed server-side by [DEV] fix WP status when only have additional payments topcoder-platform/taas-apis#491

4. Need to fix validation.

5. Can we make the default value empty instead of 0?

6. let's disable the "additional payment" option if there is no BA assigned to the corresponding Resource Booking and when we put mouse on it show tooltip: Billing Account is not set for the Resource Booking.

   The second part would be handled as a separate issue [$40] Make toastr messages always visible #95

   the red toastr message is not visible if the resources per page is more and the modal also is still opened which is causing confusion.

7. Need to fix.

@MadOPcode feel free to pick up this issue as per this comment.

[sandhiyakavi]

Issue points 2 and 3 are not yet fixed.

Other issues are fixed and working fine.

1. Not able to process Additional payments for future week.
   

2. Able to enter only two digits after the decimal point.
   

3. Textbox is now empty.
   

4. Additional payment option disabled if no BA assigned and tooltip is displayed.
   

5. Text displayed correctly in the modal.
   

[maxceem]

@sandhiyakavi Issue points 2 and 3 should be fixed now.

[sandhiyakavi]

@maxceem If we do Additional payment for the WP which is in 'pending' status, it is still changing into 'partially completed' status.

If 'No days' status and we process Additional payment, the status changing correctly into 'in progress' status.

[maxceem]

@sandhiyakavi this WP has 1 working days, but 0 working days were paid. As some payment was done (additional one), we indicate it as partially completed status.

[maxceem]

Challenge https://www.topcoder.com/challenges/add1a560-96ce-4330-933d-20f0b50fd46d has been created for this ticket.

This is an automated message for maxceem via Topcoder X

[maxceem]

Challenge https://www.topcoder.com/challenges/add1a560-96ce-4330-933d-20f0b50fd46d has been assigned to madopcode.

This is an automated message for maxceem via Topcoder X

[maxceem]

Payment task has been updated: https://www.topcoder.com/challenges/add1a560-96ce-4330-933d-20f0b50fd46d
Payments Complete
Winner: madopcode
Copilot: maxceem
Challenge add1a560-96ce-4330-933d-20f0b50fd46d has been paid and closed.

This is an automated message for maxceem via Topcoder X

[sandhiyakavi]

Verified on Prod Env. Working as expected.

cc: @nkumar-topcoder