This repository was archived by the owner on Mar 13, 2025. It is now read-only.
Roles page updates #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix an issue which was allowing users to be able to add non-existing skills. * The `Typeahead` component was also firing the `onChange` event on Blur, Enter and Esc presses. * To overcome this, added a property (`enforceListOnlySelection`) to the component. If it's set, the `onChange` event will be fired only if the input is in the suggestion list. * Add `minLengthForSuggestions` property to the `Typeahead` component. * This is the minimum length to retrieve & display suggestions and was hardcoded (with 3) in the component. * The new property allows to specify it. The ability to set it to `1` is useful for displaying skills like `C`, `C#`, which have less than 3 characters. Adresses https://github.com/topcoder-platform/taas-app/issues/426
* Remove +/- buttons in the integer fields of Roles form. * Allow manual input in the integer fields. * Add a logic to make time conversion between human-readable strings (e.g. "2 weeks") and numeric hours (336). * Add proper validations on manual inputs. Addresses: https://github.com/topcoder-platform/taas-app/issues/425, https://github.com/topcoder-platform/taas-app/issues/403#issuecomment-892774361
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(55641f6) fix(roles): do not allow manual skill selection (if not in the list)
Fix an issue that was allowing users to be able to add non-existing skills.
Typeaheadcomponent was also firing theonChangeevent on Blur, Enter and Esc presses.enforceListOnlySelection) to the component. If it's set, theonChangeevent will be fired only if the input is in the suggestion list.Add
minLengthForSuggestionsproperty to theTypeaheadcomponent.1is useful for displaying skills likeC,C#, which have less than 3 characters.Adresses topcoder-platform/taas-app#426
(6104e7d) feat(roles): allow manual inputs in integer fields
Addresses: topcoder-platform/taas-app#425, topcoder-platform/taas-app#403 (comment)