Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

When entering symbols/non-existent skills on the skills field, the symbol/value is added to the skill list #104

Closed
sdgun opened this issue Aug 4, 2021 · 4 comments
Closed

When entering symbols/non-existent skills on the skills field, the symbol/value is added to the skill list #104

sdgun opened this issue Aug 4, 2021 · 4 comments
Labels
bug Something isn't working P2 QA Pass on Dev QA Pass on Prod
Milestone
mfe-taas-admin-ap...

Comments

@sdgun
Copy link
Collaborator

sdgun commented Aug 4, 2021

Steps

Go to TAAS Admin >> Roles
Click create new role button
Click on skills field and enter 'C#' or a non-existent skill (ex- 'abc')

You will not see C# in the skill suggestions drop down, but it is being added to the skill list. And No suggestions will be displayed until you click on some fields a few times

Note: Skills like C#, F# should be displayed in the suggestions in this case. But the suggestions start showing only after at least 3 letters are entered in the skills field

2021-08-04_10-42-39.mp4
@sdgun sdgun changed the title When entering symbols on the skills field, the symbol is added to the skill list When entering symbols/non-existent skills on the skills field, the symbol is added to the skill list Aug 4, 2021
@sdgun sdgun changed the title When entering symbols/non-existent skills on the skills field, the symbol is added to the skill list When entering symbols/non-existent skills on the skills field, the symbol/value is added to the skill list Aug 4, 2021
cagdas001 referenced this issue in cagdas001/micro-frontends-taas-admin-app Aug 9, 2021
@cagdas001
fix(roles): do not allow manual skill selection (if not in the list)
55641f6 
* Fix an issue which was allowing users to be able to add non-existing skills.
  * The `Typeahead` component was also firing the `onChange` event on Blur, Enter and Esc presses.
  * To overcome this, added a property (`enforceListOnlySelection`) to the component. If it's set, the `onChange` event will be fired only if the input is in the suggestion list.
* Add `minLengthForSuggestions` property to the `Typeahead` component.
  * This is the minimum length to retrieve & display suggestions and was hardcoded (with 3) in the component.
  * The new property allows to specify it. The ability to set it to `1` is useful for displaying skills like `C`, `C#`, which have less than 3 characters.

Adresses https://github.com/topcoder-platform/taas-app/issues/426
@sdgun
Copy link
Collaborator Author

sdgun commented Aug 10, 2021

verified in Dev, this issue is fixed.

@lakshmiathreya
Copy link

Verified in Prod. However, the error message needs to be improved. @sdgun pls link the Issue for that here.

@lakshmiathreya
Copy link

Screenshot 2021-08-16 at 4 04 45 PM

@sdgun
Copy link
Collaborator Author

sdgun commented Aug 16, 2021

Verified in Prod. However, the error message needs to be improved. @sdgun pls link the Issue for that here.

Created issue #102

@sdgun sdgun closed this as completed Aug 16, 2021
@SathyaJayabal SathyaJayabal transferred this issue from topcoder-archive/topcoder-platform-taas-app Aug 16, 2021
@sdgun sdgun added this to the mfe-taas-admin-app-v1.1 milestone Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working P2 QA Pass on Dev QA Pass on Prod
Projects
None yet
Milestone
mfe-taas-admin-app-v1.1
Development

No branches or pull requests
2 participants
@sdgun @lakshmiathreya